Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request Timeout missing? #65

Closed
d0ugal opened this issue Jun 5, 2014 · 4 comments
Closed

Request Timeout missing? #65

d0ugal opened this issue Jun 5, 2014 · 4 comments
Labels
outdated

Comments

@d0ugal
Copy link

d0ugal commented Jun 5, 2014

The README suggests request has a timeout parameter but the actual request function doesn't seem to include it.
@asvetlov
Copy link
Member

asvetlov commented Jun 5, 2014

Yes, timeout was removed in #57
Please use

resp = yield from asyncio.wait_for(request('GET', url), timeout)

I'll update README, thanks for report.

@d0ugal
Copy link
Author

d0ugal commented Jun 5, 2014

aha, great. Thanks!

@asvetlov
Copy link
Member

asvetlov commented Jun 6, 2014

README is fixed.

@asvetlov asvetlov closed this as completed Jun 6, 2014
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@d0ugal @asvetlov