You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Now the library uses timeout only for reading data from opened socket, not for connecting stage.
So if the server don't answer I'll get a error like TimeoutError: [Errno 110] Connect call failed ('66.221.212.5', 8888) where TimeoutError is not asyncio.TimeoutError but exception derived from OSError, it's raised by OS.
Moreover, event if we put connection stage under the hood of timeout we still have a bit strange behavior: timeout will work only for connecting and reading HTTP headers but not for getting HTTP body.
I guess just to remove timeout parameter from the API and recommend to use asyncio.wait_for directly if needed.
Thoughts?
The text was updated successfully, but these errors were encountered:
Now the library uses timeout only for reading data from opened socket, not for connecting stage.
So if the server don't answer I'll get a error like
TimeoutError: [Errno 110] Connect call failed ('66.221.212.5', 8888)
whereTimeoutError
is notasyncio.TimeoutError
but exception derived fromOSError
, it's raised by OS.Moreover, event if we put connection stage under the hood of timeout we still have a bit strange behavior: timeout will work only for connecting and reading HTTP headers but not for getting HTTP body.
I guess just to remove
timeout
parameter from the API and recommend to useasyncio.wait_for
directly if needed.Thoughts?
The text was updated successfully, but these errors were encountered: