Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect behavior for timeout parameter in aiohttp.request method #57

Closed
asvetlov opened this issue May 28, 2014 · 2 comments
Closed
Labels

Comments

@asvetlov
Copy link
Member

Now the library uses timeout only for reading data from opened socket, not for connecting stage.
So if the server don't answer I'll get a error like TimeoutError: [Errno 110] Connect call failed ('66.221.212.5', 8888) where TimeoutError is not asyncio.TimeoutError but exception derived from OSError, it's raised by OS.
Moreover, event if we put connection stage under the hood of timeout we still have a bit strange behavior: timeout will work only for connecting and reading HTTP headers but not for getting HTTP body.

I guess just to remove timeout parameter from the API and recommend to use asyncio.wait_for directly if needed.

Thoughts?

@fafhrd91
Copy link
Member

i agree, timeout is redundant. let is remove it.

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants