Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Static range requests #1382

Merged
merged 19 commits into from
Nov 18, 2016
Merged

Static range requests #1382

merged 19 commits into from
Nov 18, 2016

Commits on Nov 8, 2016

  1. Add support for http range header in static file handling. 

    Generally follows  https://tools.ietf.org/html/rfc7233 however does not currently support multiple ranges in one request.
    @andrewleech @pi-anl
    andrewleech authored and pi-anl committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    3ba96f6 View commit details
    Browse the repository at this point in the history

  2. Add details to changelog and update contributors

    @andrewleech @pi-anl
    andrewleech authored and pi-anl committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    3ddd69d View commit details
    Browse the repository at this point in the history

  3. Update CHANGES.rst 

    Add PR number to change
    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    5fe0de3 View commit details
    Browse the repository at this point in the history

  4. Update CHANGES.rst 

    Revert changelog update to allow tests to run
    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    bb9c909 View commit details
    Browse the repository at this point in the history

  5. Clean up imports and formatting

    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    7b477f3 View commit details
    Browse the repository at this point in the history

  6. Refactor range header parsing into a helpers function for easy reuse

    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    943a3f6 View commit details
    Browse the repository at this point in the history

  7. Fix flake errors

    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    6d0f017 View commit details
    Browse the repository at this point in the history

  8. Use descriptive status code

    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    f82a5ef View commit details
    Browse the repository at this point in the history

  9. Fix import error and line length in test

    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    7575b21 View commit details
    Browse the repository at this point in the history

  10. Fix range support in _sendfile_system()

    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    96f92f2 View commit details
    Browse the repository at this point in the history

  11. Give more descriptive error text 

    Remove duplicate code and fix test
    @andrewleech
    andrewleech committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    1347985 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2016

  1. Refactor the core parsing of the range header into a property on Requ… 

    …est(), returns (start,end) in format ready to use in a slice of a string/bytearray for convenient reuse

Handling specific to file offset and length calculations brought back into send() of FileSender.
Similar handling could be implemented in other request handlers depending on type of data being requested.
    @andrewleech
    andrewleech committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    6e3a09f View commit details
    Browse the repository at this point in the history

  2. Clean up flake8 violations

    @andrewleech
    andrewleech committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    fec9162 View commit details
    Browse the repository at this point in the history

  3. Fixed range header parsing

    @andrewleech
    andrewleech committed Nov 10, 2016
    Configuration menu
    Copy the full SHA
    61b94c2 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2016

  1. fix import order with 'make isort'

    @andrewleech
    andrewleech committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    27d3950 View commit details
    Browse the repository at this point in the history

  2. Split up main range unit test so it doesn't take too long and timeout.

    @andrewleech
    andrewleech committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    78d3fcf View commit details
    Browse the repository at this point in the history

  3. Adhere to line length restrictions

    @andrewleech
    andrewleech committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    88d98e0 View commit details
    Browse the repository at this point in the history

  4. Improve the strictness of range header pattern match and increase tes… 

    …t coverage.
    @andrewleech
    andrewleech committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    0a2c642 View commit details
    Browse the repository at this point in the history

  5. Add test to cover invalid case of blank start and end time given

    @andrewleech
    andrewleech committed Nov 11, 2016
    Configuration menu
    Copy the full SHA
    c884825 View commit details
    Browse the repository at this point in the history