Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable keepalives for websockets #2701

Merged
merged 3 commits into from
Feb 2, 2018
Merged

Disable keepalives for websockets #2701

merged 3 commits into from
Feb 2, 2018

Conversation

asvetlov
Copy link
Member

@asvetlov asvetlov commented Feb 1, 2018

Fix for #1955

@codecov-io
Copy link

codecov-io commented Feb 1, 2018

Codecov Report

Merging #2701 into 2.3 will increase coverage by <.01%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3    #2701      +/-   ##
==========================================
+ Coverage   97.59%   97.59%   +<.01%     
==========================================
  Files          35       35              
  Lines        7432     7436       +4     
  Branches     1293     1294       +1     
==========================================
+ Hits         7253     7257       +4     
  Misses         71       71              
  Partials      108      108
Impacted Files Coverage Δ
aiohttp/web_protocol.py 90.37% <83.33%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fdd9aab...2fa858e. Read the comment docs.

@asvetlov asvetlov merged commit ad2366e into 2.3 Feb 2, 2018
@asvetlov asvetlov deleted the websocket-keepalive branch February 2, 2018 08:37
@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants