Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kwargs into run_app func. #3861

Closed

Conversation

serjshevchenko
Copy link

@serjshevchenko serjshevchenko commented Jun 21, 2019

Fix error "Got more than 8190 bytes (11194) when reading Header value is too long."

@codecov-io
Copy link

Codecov Report

Merging #3861 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
- Coverage   97.96%   97.93%   -0.03%     
==========================================
  Files          43       43              
  Lines        8588     8588              
  Branches     1373     1373              
==========================================
- Hits         8413     8411       -2     
- Misses         71       72       +1     
- Partials      104      105       +1
Impacted Files Coverage Δ
aiohttp/web.py 99.1% <ø> (ø) ⬆️
aiohttp/web_fileresponse.py 96.55% <0%> (-1.15%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4273c7f...abb4966. Read the comment docs.

@asvetlov
Copy link
Member

I understand your motivation but disagree with implementation.
I think we should go in the opposite direction: get rid of `**kwargs`` usage but enumerate and pass all parameters explicitly.
It increases the code readability and provides better type annotations.

@webknjaz webknjaz closed this Jul 29, 2019
@webknjaz webknjaz reopened this Jul 29, 2019
@asvetlov
Copy link
Member

Closing by the lack of interest by @serjshevchenko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants