Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing section comment to __all__ definition of aiohttp #3874

Merged
merged 1 commit into from Jun 26, 2019

Conversation

AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Jun 26, 2019

What do these changes do?

__all__ entries in aiohttp are diveded into sections in accordance of what subpackage they come from by comments. One comment for streams is missing, add it.

Are there changes in behavior for the user?

No

Related issue number

None

Checklist

  • I think the code is well written
  • Unit tests for the changes exist (cosmetic change, not needed)
  • Documentation reflects the changes (cosmetic change, not needed)
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt (done in Use correct style for re-exported imports #3872)
  • Add a new news fragment into the CHANGES folder (cosmetic change, not needed)

@AMDmi3 AMDmi3 requested a review from asvetlov as a code owner June 26, 2019 16:51
@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #3874 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3874   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files          43       43           
  Lines        8590     8590           
  Branches     1373     1373           
=======================================
  Hits         8413     8413           
  Misses         72       72           
  Partials      105      105
Impacted Files Coverage Δ
aiohttp/__init__.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c208cd...4cf301b. Read the comment docs.

@webknjaz webknjaz merged commit dcce5ea into aio-libs:master Jun 26, 2019
@AMDmi3 AMDmi3 deleted the add-missing-all-section-comment branch June 26, 2019 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants