New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct style for re-exported imports #3872
Conversation
Please give me some more time, I was not aware |
This pull request introduces 3 alerts and fixes 3 when merging e97120b into ac81c18 - view on LGTM.com new alerts:
fixed alerts:
|
Done. I'm not sure how to fix isort though - for me it (the same version, 4.3.21) produces a huge diff all over the module. |
You should probably do whatever isort tells you to. |
This pull request introduces 23 alerts and fixes 23 when merging bf9870c into 5c208cd - view on LGTM.com new alerts:
fixed alerts:
|
This pull request introduces 23 alerts and fixes 23 when merging 249163b into 5c208cd - view on LGTM.com new alerts:
fixed alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #3872 +/- ##
=======================================
Coverage 97.96% 97.96%
=======================================
Files 43 43
Lines 8590 8590
Branches 1373 1373
=======================================
Hits 8415 8415
Misses 71 71
Partials 104 104 Continue to review full report at Codecov.
|
I very sorry, your PR has conflicts after merging #3632 Could you please fix these conflicts? |
Updated |
Thanks! |
What do these changes do?
Use correct style for re-exported imports, makes
mypy --strict
happy.Are there changes in behavior for the user?
No
Related issue number
#3868
Checklist
CONTRIBUTORS.txt
CHANGES
folder