Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct style for re-exported imports #3872

Merged
merged 3 commits into from Jul 19, 2019

Conversation

AMDmi3
Copy link
Contributor

@AMDmi3 AMDmi3 commented Jun 26, 2019

What do these changes do?

Use correct style for re-exported imports, makes mypy --strict happy.

Are there changes in behavior for the user?

No

Related issue number

#3868

Checklist

  • I think the code is well written
  • Unit tests for the changes exist (no new code and functional changes though, so should be covered by existing tests)
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
  • Add a new news fragment into the CHANGES folder

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Jun 26, 2019

Please give me some more time, I was not aware from foo import (bar as baz) syntax is possible. Will redo the patches that way, that will also fix flake8.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 26, 2019

This pull request introduces 3 alerts and fixes 3 when merging e97120b into ac81c18 - view on LGTM.com

new alerts:

  • 3 for Module-level cyclic import

fixed alerts:

  • 3 for Module-level cyclic import

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Jun 26, 2019

Done. I'm not sure how to fix isort though - for me it (the same version, 4.3.21) produces a huge diff all over the module.

aiohttp/__init__.py Outdated Show resolved Hide resolved
@webknjaz
Copy link
Member

You should probably do whatever isort tells you to.

@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 26, 2019

This pull request introduces 23 alerts and fixes 23 when merging bf9870c into 5c208cd - view on LGTM.com

new alerts:

  • 23 for Module-level cyclic import

fixed alerts:

  • 23 for Module-level cyclic import

CHANGES/3868.bugfix Outdated Show resolved Hide resolved
@lgtm-com
Copy link
Contributor

lgtm-com bot commented Jun 26, 2019

This pull request introduces 23 alerts and fixes 23 when merging 249163b into 5c208cd - view on LGTM.com

new alerts:

  • 23 for Module-level cyclic import

fixed alerts:

  • 23 for Module-level cyclic import

@codecov-io
Copy link

codecov-io commented Jun 26, 2019

Codecov Report

Merging #3872 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3872   +/-   ##
=======================================
  Coverage   97.96%   97.96%           
=======================================
  Files          43       43           
  Lines        8590     8590           
  Branches     1373     1373           
=======================================
  Hits         8415     8415           
  Misses         71       71           
  Partials      104      104

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c208cd...249163b. Read the comment docs.

@asvetlov
Copy link
Member

asvetlov commented Jul 5, 2019

I very sorry, your PR has conflicts after merging #3632

Could you please fix these conflicts?

@AMDmi3
Copy link
Contributor Author

AMDmi3 commented Jul 15, 2019

Updated

@asvetlov asvetlov merged commit 4a2fba9 into aio-libs:master Jul 19, 2019
@asvetlov
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants