-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support websocket proxies configured via environment variables #4661
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have some concerns about this change.
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Thanks for review :) |
Co-Authored-By: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Codecov Report
@@ Coverage Diff @@
## master #4661 +/- ##
==========================================
+ Coverage 97.58% 97.59% +0.01%
==========================================
Files 43 43
Lines 8916 8916
Branches 1405 1405
==========================================
+ Hits 8701 8702 +1
Misses 95 95
+ Partials 120 119 -1
Continue to review full report at Codecov.
|
PR aio-libs#4661 Resolves aio-libs#4648 Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua>
Backport to 3.8: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply 50753ea on top of patchback/backports/3.8/50753eace15da24a9fb9774bcfcaa1dc7650164e/pr-4661 Backporting merged PR #4661 into master
🤖 @patchback |
PR aio-libs#4661 Resolves aio-libs#4648 Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> (cherry picked from commit 50753ea)
PR aio-libs#4661 Resolves aio-libs#4648 Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> (cherry picked from commit 50753ea)
…d via environment variables (#6183) Co-authored-by: Sviatoslav Sydorenko <wk.cvs.github@sydorenko.org.ua> Co-authored-by: Mariusz Masztalerczuk <mariusz@masztalerczuk.com>
What do these changes do?
Fixes a problem with the non-working configuration of the proxy
for wss (when a proxy URL was set via env var).
Are there changes in behavior for the user?
Working proxy
Related issue number
Resolves #4648
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.