Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a no-op checking job to GHA #6185

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

webknjaz
Copy link
Member

What do these changes do?

This patch adds an unconditional no-op job waiting for the testing to pass. It can be used in the branch protection rules. This will reduce the maintenance burden of having to update the checks every time the job names change.

Are there changes in behavior for the user?

Nope.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@webknjaz webknjaz added bot:chronographer:skip This PR does not need to include a change note backport-3.8 labels Oct 31, 2021
@codecov
Copy link

codecov bot commented Oct 31, 2021

Codecov Report

Merging #6185 (0add253) into master (527b1b9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #6185   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         102      102           
  Lines       30351    30351           
  Branches     2729     2729           
=======================================
  Hits        28315    28315           
  Misses       1858     1858           
  Partials      178      178           
Flag Coverage Δ
unit 93.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527b1b9...0add253. Read the comment docs.

@webknjaz webknjaz merged commit 15f4411 into aio-libs:master Oct 31, 2021
@webknjaz webknjaz deleted the maintenance/gha-check branch October 31, 2021 22:56
@patchback
Copy link
Contributor

patchback bot commented Oct 31, 2021

Backport to 3.8: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.8/15f4411d3a1e93a6e8c7cdc08cc3a0acee7b04a0/pr-6185

Backported as #6186

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Oct 31, 2021
webknjaz added a commit that referenced this pull request Oct 31, 2021
)

(cherry picked from commit 15f4411)

Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant