Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #6185/15f4411d backport][3.8] Add a no-op checking job to GHA #6186

Conversation

patchback[bot]
Copy link
Contributor

@patchback patchback bot commented Oct 31, 2021

This is a backport of PR #6185 as merged into master (15f4411).

What do these changes do?

This patch adds an unconditional no-op job waiting for the testing to pass. It can be used in the branch protection rules. This will reduce the maintenance burden of having to update the checks every time the job names change.

Are there changes in behavior for the user?

Nope.

Related issue number

N/A

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@patchback patchback bot requested a review from webknjaz as a code owner October 31, 2021 22:56
@patchback patchback bot mentioned this pull request Oct 31, 2021
5 tasks
@webknjaz webknjaz added the bot:chronographer:skip This PR does not need to include a change note label Oct 31, 2021
@webknjaz webknjaz merged commit c61395f into 3.8 Oct 31, 2021
@webknjaz webknjaz deleted the patchback/backports/3.8/15f4411d3a1e93a6e8c7cdc08cc3a0acee7b04a0/pr-6185 branch October 31, 2021 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant