Fix unicode errors (#7044) #7099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
Dreamsorcerer
approved these changes
Nov 22, 2022
Fix few errors related to Unicode decoding.
* multipart forms with invalid utf-8 characters as data can cause a
UnicodeDecodeError to be raised. This should be raised as ValueError,
like what is done in other parts of the code base.
* HTTP request parser (pure-python) tries to decode the header name with
utf-8/xmlcharrefreplace, which cannot decode bytes such as `\xd9`.
I don't think so.
<!-- Are there any issues opened that will be resolved by merging this
change? -->
- [x] I think the code is well written
- [x] Unit tests for the changes exist
- [ ] ~Documentation reflects the changes~
- [ ] If you provide code modification, please add yourself to
`CONTRIBUTORS.txt`
* The format is <Name> <Surname>.
* Please keep alphabetical order, the file is sorted by names.
- [x] ~Add a new news fragment into the `CHANGES` folder~
* name it `<issue_id>.<type>` for example (588.bugfix)
* if you don't have an `issue_id` change it to the pr id after creating
the pr
* ensure type is one of the following:
* `.feature`: Signifying a new feature.
* `.bugfix`: Signifying a bug fix.
* `.doc`: Signifying a documentation improvement.
* `.removal`: Signifying a deprecation or removal of public API.
* `.misc`: A ticket has been closed, but it is not of interest to users.
* Make sure to use full sentences with correct case and punctuation, for
example: "Fix issue with non-ascii contents in doctest text files."
(cherry picked from commit bce6e3c)
ret2libc
force-pushed
the
patchback/backports/3.9/bce6e3c7324f53342bcd225103771c509fc4a67f/pr-7044
branch
from
7f247f3
to
70a56f6
Compare
Codecov Report
@@ Coverage Diff @@
## 3.9 #7099 +/- ##
=======================================
Coverage 97.31% 97.31%
=======================================
Files 103 103
Lines 30248 30265 +17
Branches 3760 3763 +3
=======================================
+ Hits 29435 29453 +18
+ Misses 618 617 -1
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@Dreamsorcerer are those errors in macos and windows caused by me? |
No, CI is passed. Those 2 are still marked experimental. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix few errors related to Unicode decoding.
\xd9.I don't think so.
Documentation reflects the changesCONTRIBUTORS.txtAdd a new news fragment into theCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature. *.bugfix: Signifying a bug fix. *.doc: Signifying a documentation improvement. *.removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.(cherry picked from commit bce6e3c)
What do these changes do?
Are there changes in behavior for the user?
Related issue number
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.