Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unicode errors (#7044) #7099

Commits on Nov 22, 2022

  1. Fix unicode errors (aio-libs#7044)

    Fix few errors related to Unicode decoding.
    * multipart forms with invalid utf-8 characters as data can cause a
    UnicodeDecodeError to be raised. This should be raised as ValueError,
    like what is done in other parts of the code base.
    * HTTP request parser (pure-python) tries to decode the header name with
    utf-8/xmlcharrefreplace, which cannot decode bytes such as `\xd9`.
    
    I don't think so.
    
    <!-- Are there any issues opened that will be resolved by merging this
    change? -->
    
    - [x] I think the code is well written
    - [x] Unit tests for the changes exist
    - [ ] ~Documentation reflects the changes~
    - [ ] If you provide code modification, please add yourself to
    `CONTRIBUTORS.txt`
      * The format is &lt;Name&gt; &lt;Surname&gt;.
      * Please keep alphabetical order, the file is sorted by names.
    - [x] ~Add a new news fragment into the `CHANGES` folder~
      * name it `<issue_id>.<type>` for example (588.bugfix)
    * if you don't have an `issue_id` change it to the pr id after creating
    the pr
      * ensure type is one of the following:
        * `.feature`: Signifying a new feature.
        * `.bugfix`: Signifying a bug fix.
        * `.doc`: Signifying a documentation improvement.
        * `.removal`: Signifying a deprecation or removal of public API.
    * `.misc`: A ticket has been closed, but it is not of interest to users.
    * Make sure to use full sentences with correct case and punctuation, for
    example: "Fix issue with non-ascii contents in doctest text files."
    
    (cherry picked from commit bce6e3c)
    ret2libc committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    70a56f6 View commit details
    Browse the repository at this point in the history