This repository has been archived by the owner on Feb 21, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@popravich it should be merged ASAP, sorry fo the bug introduced plus no detection in the UT. I will do another MR to have support for Python 3.6.2, using the Python implementation.
We detected that issue together with @argaen when the new Python RC was tested with aiocache.
We have been running our system with that version since it was published, we didn't notice any particular issue. I guess that having a pool overallocated of opened connections has hide that mistake.