Skip to content
This repository has been archived by the owner on Feb 21, 2023. It is now read-only.

Fix critical bug with patched Lock #256

Merged
merged 1 commit into from
Jun 30, 2017

Conversation

pfreixes
Copy link
Contributor

@popravich it should be merged ASAP, sorry fo the bug introduced plus no detection in the UT. I will do another MR to have support for Python 3.6.2, using the Python implementation.

We detected that issue together with @argaen when the new Python RC was tested with aiocache.

We have been running our system with that version since it was published, we didn't notice any particular issue. I guess that having a pool overallocated of opened connections has hide that mistake.

@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #256 into master will decrease coverage by 9.87%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #256      +/-   ##
=========================================
- Coverage   96.97%   87.1%   -9.88%     
=========================================
  Files          57      57              
  Lines        7449    7450       +1     
  Branches      587     587              
=========================================
- Hits         7224    6489     -735     
- Misses        168     872     +704     
- Partials       57      89      +32
Impacted Files Coverage Δ
aioredis/locks.py 95.65% <100%> (-4.35%) ⬇️
tests/geo_commands_test.py 18.46% <0%> (-81.54%) ⬇️
tests/sentinel_commands_test.py 18.6% <0%> (-81.4%) ⬇️
aioredis/commands/geo.py 22.53% <0%> (-77.47%) ⬇️
tests/ssl_test.py 23.52% <0%> (-76.48%) ⬇️
tests/sentinel_failover_test.py 12.78% <0%> (-75.19%) ⬇️
aioredis/sentinel/commands.py 37.03% <0%> (-60.5%) ⬇️
aioredis/log.py 45.45% <0%> (-54.55%) ⬇️
tests/conftest.py 58.89% <0%> (-31.58%) ⬇️
aioredis/commands/generic.py 81.37% <0%> (-18.63%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f73783...5e671fe. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 29, 2017

Codecov Report

Merging #256 into master will decrease coverage by 9.87%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #256      +/-   ##
=========================================
- Coverage   96.97%   87.1%   -9.88%     
=========================================
  Files          57      57              
  Lines        7449    7450       +1     
  Branches      587     587              
=========================================
- Hits         7224    6489     -735     
- Misses        168     872     +704     
- Partials       57      89      +32
Impacted Files Coverage Δ
aioredis/locks.py 95.65% <100%> (-4.35%) ⬇️
tests/geo_commands_test.py 18.46% <0%> (-81.54%) ⬇️
tests/sentinel_commands_test.py 18.6% <0%> (-81.4%) ⬇️
aioredis/commands/geo.py 22.53% <0%> (-77.47%) ⬇️
tests/ssl_test.py 23.52% <0%> (-76.48%) ⬇️
tests/sentinel_failover_test.py 12.78% <0%> (-75.19%) ⬇️
aioredis/sentinel/commands.py 37.03% <0%> (-60.5%) ⬇️
aioredis/log.py 45.45% <0%> (-54.55%) ⬇️
tests/conftest.py 58.89% <0%> (-31.58%) ⬇️
aioredis/commands/generic.py 81.37% <0%> (-18.63%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f73783...5e671fe. Read the comment docs.

@pfreixes
Copy link
Contributor Author

A really weird error in Travis regarding some firs steps to get ready the environment ...

@popravich
Copy link
Contributor

Can you resubmit the PR into v0.3 branch?

@pfreixes
Copy link
Contributor Author

#257

@popravich
Copy link
Contributor

Released v1.0.0b2 and v0.3.3

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants