Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed an old now non-working feature from documentation #1060

Merged
merged 3 commits into from
Nov 6, 2022
Merged

Removed an old now non-working feature from documentation #1060

merged 3 commits into from
Nov 6, 2022

Conversation

Desiders
Copy link
Contributor

@Desiders Desiders commented Nov 5, 2022

Description

include_router method in Router has an old now non-working feature still documented. It was removed in #897.

Type of change

  • Documentation (typos, documentation)

@github-actions github-actions bot added the 3.x Issue or PR for stable 3.x version label Nov 5, 2022
@github-actions
Copy link

github-actions bot commented Nov 5, 2022

✔️ Changelog found.

Thank you for adding a description of the changes

@evgfilim1 evgfilim1 changed the title Removed an old now non-working feature Removed an old now non-working feature from documentation Nov 6, 2022
@evgfilim1 evgfilim1 added the docs Something is missing in docs label Nov 6, 2022
@codecov
Copy link

codecov bot commented Nov 6, 2022

Codecov Report

Merging #1060 (64d40f9) into dev-3.x (b8cd06f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x     #1060   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          302       302           
  Lines         8171      8171           
=========================================
  Hits          8171      8171           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/router.py 100.00% <100.00%> (ø)

@JrooTJunior JrooTJunior merged commit 08d35ed into aiogram:dev-3.x Nov 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version docs Something is missing in docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants