Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#896 Restrict including routers with strings #897

Merged
merged 2 commits into from
Apr 25, 2022
Merged

#896 Restrict including routers with strings #897

merged 2 commits into from
Apr 25, 2022

Conversation

JrooTJunior
Copy link
Member

Description

Fixes #896

Type of change

Please delete options that are not relevant.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@JrooTJunior JrooTJunior added breaking This breaks backwards-compatibility 3.x Issue or PR for stable 3.x version labels Apr 25, 2022
@JrooTJunior JrooTJunior added this to the 3.0 milestone Apr 25, 2022
@JrooTJunior JrooTJunior added this to In progress in 3.0 via automation Apr 25, 2022
@github-actions
Copy link

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #897 (d8de1cc) into dev-3.x (4fb77a3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           dev-3.x      #897   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          301       300    -1     
  Lines         8192      8172   -20     
=========================================
- Hits          8192      8172   -20     
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/dispatcher/router.py 100.00% <ø> (ø)

@JrooTJunior JrooTJunior merged commit f2e02e2 into dev-3.x Apr 25, 2022
3.0 automation moved this from In progress to Done Apr 25, 2022
@JrooTJunior JrooTJunior linked an issue Apr 25, 2022 that may be closed by this pull request
@JrooTJunior JrooTJunior deleted the misc/896 branch June 25, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version breaking This breaks backwards-compatibility
Projects
3.0
  
Done
Development

Successfully merging this pull request may close these issues.

[3.x] Restrict including routers with strings
1 participant