Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle additional key combinations #12

Open
aiongg opened this issue Mar 21, 2023 · 0 comments
Open

Handle additional key combinations #12

aiongg opened this issue Mar 21, 2023 · 0 comments
Labels

Comments

@aiongg
Copy link
Owner

aiongg commented Mar 21, 2023

Currently for many key combinations, we collect them but do not handle them. We need to decide which combinations we will handle and for what purposes, and otherwise allow them to be passed back to Windows. For example, Shift + Arrow keys normally allows the user to select text in the input field. We probably want to keep this behavior, so we should not collect Shift + Arrow.

These checks and pass/reject should happen somewhere in KeyEventSink.

@aiongg aiongg added the windows label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant