Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correctly handling the compact during sync config setting #807

Merged
merged 1 commit into from
Feb 6, 2019

Conversation

AlexandraRoatis
Copy link
Contributor

Description

The message to disable sync was correctly read from the config file, but not relayed to TaskImportBlocks. This PR fixes the issue.

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Enhancement.
  • Unit test.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • existing tests suite

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AlexandraRoatis AlexandraRoatis added the bug Something isn't working label Feb 5, 2019
@AlexandraRoatis AlexandraRoatis added this to the 0.3.3 milestone Feb 5, 2019
@AlexandraRoatis AlexandraRoatis merged commit 2239a06 into master-pre-merge Feb 6, 2019
@AlexandraRoatis AlexandraRoatis deleted the disable-compact branch February 6, 2019 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants