Certificate and buffer capacity #89
Comments
|
Hello! I'm glad To be honest this is the first time I've seen the capacity of these buffers exceeded. I'm glad a proper exception was raised rather than a crash in our C code, that at least is good news! I'm a bit surprised, as 4096 bytes means that the certificate is already going to span 3 packets, how large is the certificate + chain? I have no problem raising the size of all these buffers to 8192, would that be sufficient or do we need to go up to 16384 as you did? Jeremy |
|
One warning though: I'm not sure using On a semi-related note, have you considered using |
Unfortunately we'd like to maintain Python 2 compatibility as much as possible, so we'll probably need to stick with pywebsocket. |
|
I was talking about WebRTC, not WebSockets ;)
|
|
I'm very sorry. I clearly was not caffeinated enough this morning :)
And I'm not an expert on WebRTC I'm not sure how it's tested right now.
…On Thu., Apr. 30, 2020, 12:13 Jeremy Lainé, ***@***.***> wrote:
I was talking about WebRTC, not WebSockets ;)
aiortc gives you a browserless WebRTC stack in Python.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#89 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK6ZDA63X2LPLYPFSO5OQTRPGPRZANCNFSM4MVM7EMQ>
.
|
|
Thank you. Apparently 8192 doesn't work and 16384 works for me. |
|
OK thanks. Could you point me to your certificate please, as I don't think I've ever seen one so large? |
|
web-platform.test.pem and web-platform.test.key in https://github.com/web-platform-tests/wpt/tree/master/tools/certs. |
|
It could be because of our super long domain list.
…On Fri., May 1, 2020, 06:10 Yutaka Hirano, ***@***.***> wrote:
web-platform.test.pem and web-platform.test.key in
https://github.com/web-platform-tests/wpt/tree/master/tools/certs.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#89 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAK6ZDHNVSL4PFDGWVCPNXTRPKNXXANCNFSM4MVM7EMQ>
.
|
jlaine
added a commit
to jlaine/aioquic
that referenced
this issue
May 2, 2020
|
@Hexcles it definitely is due to the long domain list, just run:
which gives you: |
jlaine
added a commit
to jlaine/aioquic
that referenced
this issue
May 4, 2020
|
@yutakahirano master should now work for your usecase. I aim to have new release on PyPI before the end of the week |
|
Thank you very much! |
|
Huh. And I failed to produce the promised release.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
Thank you very much for developing this!
We are trying to use this as a test server in web-platform-tests, and I have one problem: the server throws with our certificates.
With web-platform.test.pem and web-platform.test.key in https://github.com/web-platform-tests/wpt/tree/master/tools/certs, it throws an BufferWriteError.
I found this can be workarounded by changing a buffer capacity in aioquic/quic/connection.py.
Is this a known issue? Is there any clean solution?
Thank you!
The text was updated successfully, but these errors were encountered: