Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(htn): Remove ACTION_BASED class from HTN planning problem kind. #523

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

arbimo
Copy link
Member

@arbimo arbimo commented Nov 17, 2023

While it historically made sense to have it there, it prevented pure HTN planners from declaring
that they do not support non-hierarchical planning.

Note that this is purely backward compatible (surprisingly).

While it made sense to have it there, it would prevent pure HTN planner from declaring
that they do not support purely non-hierarchical planning.
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (73cacaa) 84.92% compared to head (2b2866d) 84.92%.

Files Patch % Lines
unified_planning/test/examples/hierarchical.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
- Coverage   84.92%   84.92%   -0.01%     
==========================================
  Files         200      200              
  Lines       26383    26385       +2     
==========================================
+ Hits        22407    22408       +1     
- Misses       3976     3977       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@alvalentini alvalentini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alvalentini alvalentini merged commit 4473e4c into master Nov 17, 2023
8 checks passed
@alvalentini alvalentini deleted the fix-htn-kind branch November 17, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants