Terminal text gets garbled on Windows

[SonarBeserk]

Whenever running air on windows the text has issues printing.

λ c:\Users\sonar\.air .

             _
     /\     (_)
    /  \     _   _ __
   / /\ \   | | | '__|
  / ____ \  | | | |
 /_/    \_\ |_| |_|

Live reload for Go apps :)

[19:38:14.574] watching .
[19:38:14.577] watching protos
[19:38:14.579] !exclude tmp
[19:38:14.580] building...
[19:3[81:91:53.83:2155]. 3!2e6x]c l!uedxec ltumdpe
 tmp[
19:38:15.329] !exclude tmp
[19:38:15.341] running...

I get this issue running in git bash as well as cmd.

[cosmtrek]

Thanks for your report. I'll take time to figure it out. Could you tell me what's your project structure and your Windows version?

[SonarBeserk]

I have a single main.go file in the directory that runs an http server. I am running Windows 10 Pro Build 14393

[cosmtrek]

@mattn Could you help me look at this issue when you have free time? Actually I have no idea how to solve it because I'm not familiar with Windows terminal, thanks a lot!

@SonarBeserk I'm very sorry for this, it may take long time to fix it. Could you try to fix it if you are able to?

[mattn]

Hi, I'll look into it in later.

[mattn]

garbage is mixed log-output.

[19:3[81:91:53.83:2155]. 3!2e6x]c l!uedxec ltumdpe

You must use sync.Mutex to avoid mixed output.

[cosmtrek]

@mattn Did you mean this? bf222c2

[mattn]

Yes, it fixed this issue on my environment.

[mattn]

I found another issue.

I think os.Remove should be called before go build.

[cosmtrek]

@mattn os.Remove just delete the old binary file, actually it's OK to remain this file because the new binary file will overwrite this old one. Could you provide the error?

[mattn]

Yes, sequence should be

1. kill process
2. remove tmp/main.exe
3. go build (generate tmp/main.exe)

but as far as I see the output, seems to be:

1. kill process
2. go build (generate tmp/main.exe)
3. remove tmp/main.exe

[mattn]

Windows can't overwrite file while another process(or it-self) open the file.

[cosmtrek]

@mattn Got it, I'll fix this.

[cosmtrek]

@mattn I've fixed it, and found another interesting issue about the colorful output.

See the picture follows:

Text in magenta color is invisible in PowerShell... Maybe blame it :)

[cosmtrek]

@SonarBeserk I've fixed some problems on Windows, could you try a new binary?

curl -fLo ~/.air.exe \
    https://raw.githubusercontent.com/cosmtrek/air/master/bin/windows/air.exe

[cosmtrek]

Oops, this issue is closed automatically since current branch fix-2 was merged by master...

[SonarBeserk]

Looks fine, I don't use powershell for go development so that's not something of personal concern. It might be better to open a separate ticket to fix that issue.