Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowkaseBrowserActivity does not open Components/Colors/Typography #314

Open
dostalleos opened this issue Apr 4, 2023 · 6 comments
Open

Comments

@dostalleos
Copy link

I'm using Showkase.getBrowserIntent(context) to start the browser activity with my previews. It starts and shows the options (Components, Colors, and Typography) correctly.

But if click on any option, only the AppBar changes its title, but the content stays the same. Please check the screenshots below.

It used to work without any issues. Unfortunately, I don't know when it started. I think that it's not caused by any Showkase SDK update. I suspect Compose SDK.

Showkase version: 1.0.0-beta18
Compose version: 1.4.0

image
image
image

@oas004
Copy link
Contributor

oas004 commented Apr 4, 2023

Hi, thanks for the report! Is this maybe the same issue as this? #310

@dostalleos
Copy link
Author

dostalleos commented Apr 4, 2023

Yeah, it looks similar. But I'm not experiencing any crashes.

I'm using the following dependencies (latest stable versions):
Compose navigation v2.5.3
Accompanist Navigation v0.30.0

It works with Accompanist Navigation v0.28.0.

Are you planning to update the SDK to work with the latest stable versions?

@oas004
Copy link
Contributor

oas004 commented Apr 4, 2023

Hm, It looked very similar at least 🤔

For updating, I think we should bump some of the versions. Maybe we should configure renovate to do it more effortlessly :) Wdyt @vinaygaba ? :)

@dostalleos
Copy link
Author

It works again with accompanist navigation v0.30.1.

@SohelMNumerator
Copy link

It works again with accompanist navigation v0.30.1.

For me, this didn't work. @oas004 Any other suggestions?

@joselamar
Copy link

Experiencing same behaviour

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants