Fix problems with the @immutable annotation

Summary: Fixed classes that were marked as @immutable but clearly weren't

Test Plan: unit tests, re-run findbugs

src/com/facebook/buck/rules/DependencyGraph.java

@@ -23,9 +23,6 @@
 
 import java.util.Map;
 
-import javax.annotation.concurrent.Immutable;
-
-@Immutable
 public class DependencyGraph extends DefaultImmutableDirectedAcyclicGraph<BuildRule> {
 
   private Map<BuildTarget, BuildRule> index;

src/com/facebook/buck/test/TestResultSummary.java

@@ -19,38 +19,35 @@
 import com.facebook.buck.test.result.type.ResultType;
 import com.facebook.buck.util.Ansi;
 import com.facebook.buck.util.TimeFormat;
+import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonIgnore;
+import com.fasterxml.jackson.annotation.JsonProperty;
 
 import javax.annotation.Nullable;
 import javax.annotation.concurrent.Immutable;
 
 @Immutable
 public class TestResultSummary {
 
-  private String testCaseName;
+  private final String testCaseName;
 
-  private String testName;
+  private final String testName;
 
-  private ResultType type;
+  private final ResultType type;
 
-  private long time;
+  private final long time;
 
   @Nullable
-  private String message;
+  private final String message;
 
   @Nullable
-  private String stacktrace;
+  private final String stacktrace;
 
   @Nullable
-  private String stdOut;
+  private final String stdOut;
 
   @Nullable
-  private String stdErr;
-
-  /**
-   * Default constructor so this class can be deserialized by Jackson.
-   */
-  public TestResultSummary() {}
+  private final String stdErr;
 
   public TestResultSummary(
       String testCaseName,
@@ -71,6 +68,27 @@ public TestResultSummary(
     this.stdErr = stdErr;
   }
 
+  @JsonCreator
+  public static TestResultSummary fromJson(
+      @JsonProperty("testCaseName") String testCaseName,
+      @JsonProperty("testCase") String testName,
+      @JsonProperty("type") String type,
+      @JsonProperty("time") long time,
+      @JsonProperty("message") @Nullable String message,
+      @JsonProperty("stacktrace") @Nullable String stacktrace,
+      @JsonProperty("stdOut") @Nullable String stdOut,
+      @JsonProperty("stdErr") @Nullable String stdErr) {
+    return new TestResultSummary(
+        testCaseName,
+        testName,
+        ResultType.valueOf(type),
+        time,
+        message,
+        stacktrace,
+        stdOut,
+        stdErr);
+  }
+
   public String getTestName() {
     return testName;
   }
@@ -86,10 +104,6 @@ public boolean isSuccess() {
     return type != ResultType.FAILURE;
   }
 
-  public void setType(String stringType) {
-    type = ResultType.valueOf(stringType);
-  }
-
   public ResultType getType() {
     return type;
   }

src/com/facebook/buck/test/TestResults.java

@@ -26,12 +26,9 @@
 
 import java.util.List;
 
-import javax.annotation.concurrent.Immutable;
-
 /**
  * Represents the test results from multiple test cases.
  */
-@Immutable
 public class TestResults {
 
   private static final BuildTarget DUMMY_TARGET_FOR_TESTING = new BuildTarget("//foo/bar", "baz");