Digging into leap year bug and improvming tests #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistercrunch
force-pushed
the
fix_dates
branch
from
a4f61a4
to
34709c8
Compare
|
LGTM |
mistercrunch
added a commit
that referenced
this pull request
Mar 1, 2016
Digging into leap year bug and improvming tests
hughhhh
added a commit
to lyft/incubator-superset
that referenced
this pull request
Apr 1, 2018
[Pending with c5.large upgrade] Cache is getting overloaded lets set the range to 3 days NOT PASSING TESTS
john-bodley
added a commit
to john-bodley/superset
that referenced
this pull request
Aug 7, 2019
…x-travis [cherry] Picking a few cherries to remedy the Travis issues
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimately the fix was to run parsedatetime off of their
masterbranch in production. I still want to add the tests and the more generic raise here.