-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the dashed line when using time compare #160
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -5,6 +5,7 @@ require('nvd3'); | |||
|
|||
// CSS | |||
require('../node_modules/nvd3/build/nv.d3.min.css'); | |||
require('./nvd3_vis.css') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
with all of this linting I have to nit ask for a semi-colon
oh! |
👍 |
mistercrunch
added a commit
that referenced
this pull request
Mar 2, 2016
Fixing the dashed line when using time compare
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
…189 (apache#160) Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.188...v0.0.189) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
…189 (apache#160) Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.188...v0.0.189) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* build: speedup storybook build * build: noParse for jquery and d3 * fix: remove unused * build: add more ignore * fix: broken build * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * build: reduce parellism * fix: reduce parellism * fix: reduce parellism * fix: try * fix: remove src import * fix: list of lib * fix: list of lib * fix: keep fixing * fix: keep fixing * fix: disable mapbox * fix: bug * fix: disable another * fix: remove unused commands * fix: add comments
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
…189 (apache#160) Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.188...v0.0.189) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* build: speedup storybook build * build: noParse for jquery and d3 * fix: remove unused * build: add more ignore * fix: broken build * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * build: reduce parellism * fix: reduce parellism * fix: reduce parellism * fix: try * fix: remove src import * fix: list of lib * fix: list of lib * fix: keep fixing * fix: keep fixing * fix: disable mapbox * fix: bug * fix: disable another * fix: remove unused commands * fix: add comments
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
…189 (apache#160) Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.188...v0.0.189) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* build: speedup storybook build * build: noParse for jquery and d3 * fix: remove unused * build: add more ignore * fix: broken build * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * build: reduce parellism * fix: reduce parellism * fix: reduce parellism * fix: try * fix: remove src import * fix: list of lib * fix: list of lib * fix: keep fixing * fix: keep fixing * fix: disable mapbox * fix: bug * fix: disable another * fix: remove unused commands * fix: add comments
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
…189 (apache#160) Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version. - [Release notes](https://github.com/hshoff/vx/releases) - [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md) - [Commits](airbnb/visx@v0.0.188...v0.0.189) Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* build: speedup storybook build * build: noParse for jquery and d3 * fix: remove unused * build: add more ignore * fix: broken build * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * fix: adjust list of modules * build: reduce parellism * fix: reduce parellism * fix: reduce parellism * fix: try * fix: remove src import * fix: list of lib * fix: list of lib * fix: keep fixing * fix: keep fixing * fix: disable mapbox * fix: bug * fix: disable another * fix: remove unused commands * fix: add comments
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.8.0
labels
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@williaster