Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing the dashed line when using time compare #160

Merged
merged 2 commits into from
Mar 2, 2016
Merged

Conversation

mistercrunch
Copy link
Member

@@ -5,6 +5,7 @@ require('nvd3');

// CSS
require('../node_modules/nvd3/build/nv.d3.min.css');
require('./nvd3_vis.css')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with all of this linting I have to nit ask for a semi-colon

@mistercrunch
Copy link
Member Author

oh!

@williaster
Copy link
Contributor

👍

mistercrunch added a commit that referenced this pull request Mar 2, 2016
Fixing the dashed line when using time compare
@mistercrunch mistercrunch merged commit 8703fa9 into master Mar 2, 2016
@mistercrunch mistercrunch deleted the fix_dashed branch March 2, 2016 19:47
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
…189 (apache#160)

Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.188...v0.0.189)

Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
…189 (apache#160)

Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.188...v0.0.189)

Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* build: speedup storybook build

* build: noParse for jquery and d3

* fix: remove unused

* build: add more ignore

* fix: broken build

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* build: reduce parellism

* fix: reduce parellism

* fix: reduce parellism

* fix: try

* fix: remove src import

* fix: list of lib

* fix: list of lib

* fix: keep fixing

* fix: keep fixing

* fix: disable mapbox

* fix: bug

* fix: disable another

* fix: remove unused commands

* fix: add comments
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
…189 (apache#160)

Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.188...v0.0.189)

Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* build: speedup storybook build

* build: noParse for jquery and d3

* fix: remove unused

* build: add more ignore

* fix: broken build

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* build: reduce parellism

* fix: reduce parellism

* fix: reduce parellism

* fix: try

* fix: remove src import

* fix: list of lib

* fix: list of lib

* fix: keep fixing

* fix: keep fixing

* fix: disable mapbox

* fix: bug

* fix: disable another

* fix: remove unused commands

* fix: add comments
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
…189 (apache#160)

Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.188...v0.0.189)

Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* build: speedup storybook build

* build: noParse for jquery and d3

* fix: remove unused

* build: add more ignore

* fix: broken build

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* build: reduce parellism

* fix: reduce parellism

* fix: reduce parellism

* fix: try

* fix: remove src import

* fix: list of lib

* fix: list of lib

* fix: keep fixing

* fix: keep fixing

* fix: disable mapbox

* fix: bug

* fix: disable another

* fix: remove unused commands

* fix: add comments
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
…189 (apache#160)

Updates the requirements on [@vx/responsive](https://github.com/hshoff/vx) to permit the latest version.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.188...v0.0.189)

Signed-off-by: dependabot[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* build: speedup storybook build

* build: noParse for jquery and d3

* fix: remove unused

* build: add more ignore

* fix: broken build

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* fix: adjust list of modules

* build: reduce parellism

* fix: reduce parellism

* fix: reduce parellism

* fix: try

* fix: remove src import

* fix: list of lib

* fix: list of lib

* fix: keep fixing

* fix: keep fixing

* fix: disable mapbox

* fix: bug

* fix: disable another

* fix: remove unused commands

* fix: add comments
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants