Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shipping with CSS templates out of the box #163

Merged
merged 2 commits into from
Mar 5, 2016
Merged

Shipping with CSS templates out of the box #163

merged 2 commits into from
Mar 5, 2016

Conversation

mistercrunch
Copy link
Member

@williaster
Also the modal becomes opacity 50% while editing css and moving the mouse out of the modal.

.widget.pivot_table td,th {
padding: 1px 5px;
font-size: small;
.table tr>th {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's generally really bad to use the !important flag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how else to compete with the very high selectivity css in the bootstrap/dataTables css...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that can be tricky sometimes, okay.

@williaster
Copy link
Contributor

@mistercrunch this seems okay overall to me, but how are you thinking about this in relation to the overall bootstrap theme? Seems like we can ship that for devs that want to customize bootstrap vars, and use this as an easier interface for updating styles int he browser itself?

also what library is used to check the .css syntax in the modal? it was making suggestions for me like "this rule is too specific" that were actually wrong!

@mistercrunch
Copy link
Member Author

Oh, so the wrong suggestion would be coming from ace I guess, we can probably shut this feature down or help fixing ace.

The theming is to allow people to customize the look and feel of individual dashboards by applying templates and modifying them. That css lives on top of the bootstrap theme and only affects individual dashboards. Live updating is a cool feature I think that makes iterating on designs quick.

@williaster
Copy link
Contributor

👍

mistercrunch added a commit that referenced this pull request Mar 5, 2016
Shipping with CSS templates out of the box
@mistercrunch mistercrunch merged commit bfa6d13 into master Mar 5, 2016
@mistercrunch mistercrunch deleted the css branch March 5, 2016 04:38
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants