Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting travis to build the npm related stuff #168

Merged
merged 3 commits into from
Mar 6, 2016
Merged

Conversation

mistercrunch
Copy link
Member

No description provided.

@mistercrunch mistercrunch force-pushed the travis_npm branch 2 times, most recently from b02ffa5 to ac54e44 Compare March 6, 2016 03:53
@mistercrunch mistercrunch force-pushed the travis_npm branch 3 times, most recently from dc85222 to 7dbcbd8 Compare March 6, 2016 04:34
@mistercrunch
Copy link
Member Author

Ok @williaster, this is good to go. You can find the linting messages at the bottom of the logs. Eventually it would be nice to have some way to show only the lint messages related to the PR, but if we keep master lint-free it should work.

@@ -42,7 +42,7 @@ def __get__(self, obj, objtype):
def list_minus(l, minus):
"""Returns l without what is in minus

>>> list_without([1, 2, 3], [2])
>>> list_minus([1, 2, 3], [2])
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

previous commit had a doctest that broke the build, this fixes it

@williaster
Copy link
Contributor

awesome! I can add the files-related-to-the-PR change on a new PR.

👍

mistercrunch added a commit that referenced this pull request Mar 6, 2016
Getting travis to build the npm related stuff
@mistercrunch mistercrunch merged commit a53dbfc into master Mar 6, 2016
@mistercrunch mistercrunch deleted the travis_npm branch March 6, 2016 13:07
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
* feat: allow chart plugin to be unregistered

* test: address edge cases
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* feat: allow chart plugin to be unregistered

* test: address edge cases
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
…e#168)

Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version.
- [Release notes](https://github.com/d3/d3-scale/releases)
- [Commits](https://github.com/d3/d3-scale/commits/v3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* feat: allow chart plugin to be unregistered

* test: address edge cases
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
…e#168)

Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version.
- [Release notes](https://github.com/d3/d3-scale/releases)
- [Commits](https://github.com/d3/d3-scale/commits/v3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* feat: allow chart plugin to be unregistered

* test: address edge cases
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
…e#168)

Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version.
- [Release notes](https://github.com/d3/d3-scale/releases)
- [Commits](https://github.com/d3/d3-scale/commits/v3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* feat: allow chart plugin to be unregistered

* test: address edge cases
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
…e#168)

Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version.
- [Release notes](https://github.com/d3/d3-scale/releases)
- [Commits](https://github.com/d3/d3-scale/commits/v3.0.1)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants