-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting travis to build the npm related stuff #168
Conversation
b02ffa5
to
ac54e44
Compare
dc85222
to
7dbcbd8
Compare
Ok @williaster, this is good to go. You can find the linting messages at the bottom of the logs. Eventually it would be nice to have some way to show only the lint messages related to the PR, but if we keep master lint-free it should work. |
@@ -42,7 +42,7 @@ def __get__(self, obj, objtype): | |||
def list_minus(l, minus): | |||
"""Returns l without what is in minus | |||
|
|||
>>> list_without([1, 2, 3], [2]) | |||
>>> list_minus([1, 2, 3], [2]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
previous commit had a doctest that broke the build, this fixes it
awesome! I can add the files-related-to-the-PR change on a new PR. 👍 |
Getting travis to build the npm related stuff
* feat: allow chart plugin to be unregistered * test: address edge cases
* feat: allow chart plugin to be unregistered * test: address edge cases
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* feat: allow chart plugin to be unregistered * test: address edge cases
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* feat: allow chart plugin to be unregistered * test: address edge cases
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
* feat: allow chart plugin to be unregistered * test: address edge cases
…e#168) Updates the requirements on [d3-scale](https://github.com/d3/d3-scale) to permit the latest version. - [Release notes](https://github.com/d3/d3-scale/releases) - [Commits](https://github.com/d3/d3-scale/commits/v3.0.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
No description provided.