Fixing the python and js packaging #172
Conversation
| @@ -1,4 +1,8 @@ | |||
| recursive-include panoramix/templates * | |||
| recursive-include panoramix/static * | |||
| recursive-exclude panoramix/static/assets/node_modules * | |||
There was a problem hiding this comment.
This excludes the thousands of files in that folder to ship with the python package
There was a problem hiding this comment.
gotcha, and they're already included in the bundled js files so are totally unnecessary
| @@ -66,7 +65,7 @@ <h4 class="modal-title" id="myModalLabel">Dashboard CSS</h4> | |||
| </div> | |||
| </div> | |||
| </div> | |||
| <div class="gridster content_fluid"> | |||
| <div class="gridster content_fluid" style="visibility: hidden;"> | |||
There was a problem hiding this comment.
css rule instead of inline style! why is this necessary? and is visibility: hidden; what you want or display: none;?
There was a problem hiding this comment.
Well I had the visibility:hidden in panoramix.css but it would flicker, while the javascript .gridster call alters the css or classes the pre and post css changes would show for a fraction of a second.
When the visibility:hidden is in panoramix.css it flickers, but not when it's inline... Let's land this so I can get this release out and we can revisit later. Also the display:none option might be better but the jquery $.show() would animate while there's already a lot going on so I went for this approach instead.
I think the location of the js (head vs tail) might have something to do with it as well, maybe all of our entry scripts should be head since they contain css now. Anyhow, I'm merging and pushing a release as this works well and we can work out the details later.
Fixing the python and js packaging
* test: extract mock plugins into separate file * fix: use constants * fix: test coverage
* test: extract mock plugins into separate file * fix: use constants * fix: test coverage
* test: extract mock plugins into separate file * fix: use constants * fix: test coverage
* test: extract mock plugins into separate file * fix: use constants * fix: test coverage
* test: extract mock plugins into separate file * fix: use constants * fix: test coverage
mistercrunch
added
🏷️ bot
@williaster
This makes it such that we don't have to ship the whole
node_moduleswith the python package, to do that I had to move a bunch ofcsshtml references to thejsrequire notation. I managed to do it for everything but thefont-awesomeone.This also cranks up the version to 0.8.0, I think it's ready to ship to Pypi.