Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sunburst improvements #184

Merged
merged 4 commits into from
Mar 18, 2016
Merged

sunburst improvements #184

merged 4 commits into from
Mar 18, 2016

Conversation

williaster
Copy link
Contributor

this commit adds some additions to the sunburst vis:

  • trim '0' groups from sunburst paths to show null groups (previously, all levels were filled in completely with filler groups even if the counts were 0; those should have been trimmed)
  • add ability to map color to sunburst groupby groups, instead of ratio. Until we refactor controls, this was implemented simply by checking if m1 == m2.
  • add fancier breadcrumbs to sunburst re derek's request

trickiest part was making sizing of breadcrumbs etc dynamic based on the number of levels and within a dasboard, but tested it a fair amount.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.44% when pulling 0608094 on chris/sunburst-fixes into 2aa0e0d on master.

@mistercrunch
Copy link
Member

screen shot 2016-03-16 at 4 21 22 pm

With long text there's some issues in the breadcrums, it's hard to ensure that it all fits in there, the colors of the breadcrum also don't match the chart.

When not hovering there's an issue of white on white because of the lack of borders. White could mean that it doens't exist or that it's just a median ratio...

…umbs, and make colors more readable for sunburst.
@landscape-bot
Copy link

Code Health
Repository health decreased by 0.44% when pulling 3197c4b on chris/sunburst-fixes into 2aa0e0d on master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 3dc9996 on mistercrunch:chris/sunburst-fixes into 2aa0e0d on mistercrunch:master.

@williaster
Copy link
Contributor Author

all right! this is what it looks like now. I think wrapping of breadcrumb text will still be gnarly beyond 2 lines but this is much better. at that point they should just increase the size of the chart on the dashboard.

image

@mistercrunch
Copy link
Member

LGTM !!!

williaster added a commit that referenced this pull request Mar 18, 2016
@williaster williaster merged commit 8f4f5b1 into master Mar 18, 2016
@williaster williaster deleted the chris/sunburst-fixes branch March 18, 2016 00:54
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.1 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants