Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing mysql install #203

Merged
merged 2 commits into from
Mar 28, 2016
Merged

Fixing mysql install #203

merged 2 commits into from
Mar 28, 2016

Conversation

mistercrunch
Copy link
Member

No description provided.

@landscape-bot
Copy link

Code Health
Repository health decreased by 0.22% when pulling 0db498c on fixes into 4a0ea5f on master.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 26c7251 on airbnb:fixes into 4a0ea5f on airbnb:master.

@@ -634,13 +634,14 @@ def fetch_metadata(self):
db.session.flush()
if not dbcol:
dbcol = TableColumn(column_name=col.name)

num_types = ('DOUBLE', 'FLOAT', 'INT', 'BIGINT')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing 'LONG' ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. The bug I fixed here with mysql was very confusing where the type was BIGINT(64) instead of just BIGINT

@coleslaw
Copy link
Contributor

👍

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 09021aa on airbnb:fixes into 4a0ea5f on airbnb:master.

@mistercrunch mistercrunch merged commit 74c72b3 into master Mar 28, 2016
@mistercrunch mistercrunch deleted the fixes branch March 28, 2016 06:03
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants