fix sunburst error. add less to package.json
#205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lains if it's not there.
| @@ -293,7 +293,7 @@ function sunburstVis(slice) { | |||
| } | |||
| var currentNode = root; | |||
| for (var j = 0; j < levels.length; j++) { | |||
| var children = currentNode.children; | |||
| var children = currentNode.children || []; | |||
There was a problem hiding this comment.
line 305 throws an error without this when children is undefined.
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
* feat: add function for parsing formatters from encoding * fix: add unit test * feat: add getter * fix: update type
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
* feat: add function for parsing formatters from encoding * fix: add unit test * feat: add getter * fix: update type
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 17, 2021
Updates the requirements on [@types/storybook__react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/storybook__react) to permit the latest version. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/storybook__react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
* feat: add function for parsing formatters from encoding * fix: add unit test * feat: add getter * fix: update type
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 24, 2021
Updates the requirements on [@types/storybook__react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/storybook__react) to permit the latest version. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/storybook__react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
* feat: add function for parsing formatters from encoding * fix: add unit test * feat: add getter * fix: update type
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 25, 2021
Updates the requirements on [@types/storybook__react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/storybook__react) to permit the latest version. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/storybook__react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
* feat: add function for parsing formatters from encoding * fix: add unit test * feat: add getter * fix: update type
zhaoyongjie
pushed a commit
to zhaoyongjie/incubator-superset
that referenced
this pull request
Nov 26, 2021
Updates the requirements on [@types/storybook__react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/storybook__react) to permit the latest version. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/storybook__react) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a JS bug that Lindsay + Dan Frank have been running into in sunbursts that they're eager to get in. See spinner here
Also on a fresh install
less-loadersays that it requireslessas a peer dependecny, so I added it topackage.jsonWe should probably also figure out devDependencies vs dependencies in package.json in the future.