-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Featured datasets #89
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
pushed a commit
to john-bodley/superset
that referenced
this pull request
Aug 15, 2018
…Pick5140 Rollback cherrypick apache#5140
graceguo-supercat
pushed a commit
to graceguo-supercat/superset
that referenced
this pull request
Oct 4, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 17, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 24, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 25, 2021
zhaoyongjie
referenced
this pull request
in zhaoyongjie/incubator-superset
Nov 26, 2021
9 tasks
mistercrunch
added
🏷️ bot
A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels
🚢 0.7.0
labels
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This creates a page for featured datasets.
Major changes:
-Adding featured datasets page and corresponding css stylesheet
-Adding is_featured to Sqlatable and Datasource models and creating a database migration for the upgrade.
-Adding user_id as an owner to Sqlatables, creating a relationship with the ab_user table, and creating a database migration for the upgrade
-Adding both is_featured and owner into the views
-Adding a link to featured datasets into the navbar
Notes:
-The database migration for user_id in Sqlatables was a little complicated. It seems that Alembic has problems with multiple alter table statements in one update, so I had to add batch_alter_tables, and it also defaulted to having no name for the constraint (which threw an error so I named it "user_id".
-Spent a while fixing the downgrade function for the sqlatables user_id db migration. I believe because I'm batch altering a table, it already has the table_name, so alembic doesn't need it when I'm calling drop_constraint and drop_column
-It looks like in views.py appbuilder shows the links in the order that you add them to the file. If we want to add featured datasets to the top, I had to put the add_link in at the top of the file, away from the featured_datasets function.
-Ran run_tests.sh and passed
Screenshot: