Mark DotLottieCache as Sendable #2245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
force-pushed
the
cal--DotLottieAnimationCache-sendable
branch
from
cac41c1
to
ad0be13
Compare
calda
changed the title
thedrick
approved these changes
Jan 8, 2024
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Jan 23, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | minor | `from: "4.3.4"` -> `from: "4.4.0"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.4.0`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.0) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.4...4.4.0) #### New features - Add privacy manifest ([airbnb/lottie-ios#2252) - Codesign Lottie.xcframework ([airbnb/lottie-ios#2259) - Add time remapping support to Core Animation rendering engine ([airbnb/lottie-ios#2286) - Add official visionOS support to lottie-ios repo ([airbnb/lottie-ios#2287) - lottie-spm now supports visionOS ([airbnb/lottie-spm#12) - Adopt policy on minimum supported Swift / Xcode version, update minimum versions to Swift 5.7 / Xcode 14.1 ([airbnb/lottie-ios#2260) #### Bug fixes - Update LottieView to display placeholder using `overlay` instead of `ZStack` ([airbnb/lottie-ios#2289) - Fix issue where Core Animation rendering engine couldn't display last frame of animation when paused ([airbnb/lottie-ios#2254) - Do not create `DotLottieImageProvider` instance if there's no image files ([airbnb/lottie-ios#2271) - Mark DotLottieCache as Sendable ([airbnb/lottie-ios#2245) - Fix issue where AnimationKeypath in SolidLayer could be incorrect ([airbnb/lottie-ios#2278) - Fix issue where Repeater could be displayed incorrectly ([airbnb/lottie-ios#2276) - Include dSYMs in xcframework build ([airbnb/lottie-ios#2284) - Fix parsing issue, add support for DotLottieConfiguration in SwiftUI LottieView ([airbnb/lottie-ios#2277) - Fix issue where DotLottieImageProvider didn't handle base64 images ([airbnb/lottie-ios#2283) - Fix issue where manually interpolated keyframes could animate incorrectly ([airbnb/lottie-ios#2285) **Full Changelog**: airbnb/lottie-ios@4.3.4...4.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR marks
DotLottieCacheasSendable, which is required to use the SwiftUILottieViewwith targeted concurrency checking enabled. Fixes #2235.This is the same approach used for
DefaultAnimationCache: https://github.com/airbnb/lottie-ios/blob/master/Sources/Public/AnimationCache/DefaultAnimationCache.swift#L67