Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CI to build for visionOS #2287

Merged
merged 15 commits into from Jan 22, 2024
Merged

Update CI to build for visionOS #2287

merged 15 commits into from Jan 22, 2024

Conversation

calda
Copy link
Member

@calda calda commented Jan 10, 2024 •
edited

This PR updates CI to build for visionOS again, now that Xcode 15.2 is released and includes the visionOS SDK.

Although visionOS is only officially supported on Apple silicon, we can build for visionOS on the GitHub actions Intel runners using this workaround:

defaults write com.apple.dt.Xcode AllowUnsupportedVisionOSHost -bool YES
defaults write com.apple.CoreSimulator AllowUnsupportedVisionOSHost -bool YES
xcodebuild -downloadPlatform visionOS

@calda calda force-pushed the cal--visionOS branch 2 times, most recently from db97ce9 to 108b213 Compare January 12, 2024 18:52
@calda
Copy link
Member Author

calda commented Jan 19, 2024 •
edited

This approach isn't going to work because:

  1. Building for visionOS requires Apple Silicon
  2. The free GitHub actions macOS runner is Intel
  3. We don't currently have the ability to upgrade to the paid Apple Silicon macOS XL runner, due to some complications with the billing setup we use in the Airbnb github.com org

Although visionOS is only officially supported on Apple silicon, we can build for visionOS on the GitHub actions Intel runners using this workaround:

defaults write com.apple.dt.Xcode AllowUnsupportedVisionOSHost -bool YES
defaults write com.apple.CoreSimulator AllowUnsupportedVisionOSHost -bool YES
xcodebuild -downloadPlatform visionOS

@calda calda closed this Jan 19, 2024
@calda calda reopened this Jan 20, 2024
@calda calda mentioned this pull request Jan 20, 2024
Closed
10 tasks
calda
calda commented Jan 20, 2024
View reviewed changes
script/test-carthage/CarthageTest/ContentView.swift
import Lottie
import SwiftUI

struct ContentView: View {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deleted the UIKit and AppKit CarthageTest apps in favor of a single cross-platform SwiftUI app that also supports visionOS and tvOS.

@calda calda marked this pull request as ready for review January 22, 2024 20:41
@calda calda enabled auto-merge (squash) January 22, 2024 21:38
@calda calda merged commit f522990 into master Jan 22, 2024
14 checks passed
@calda calda deleted the cal--visionOS branch January 22, 2024 22:23
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Jan 23, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency airbnb/lottie-spm to from: "4.4.0" (#872)
1973408 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | minor |
`from: "4.3.4"` -> `from: "4.4.0"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.4.0`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.0)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.4...4.4.0)

#### New features

- Add privacy manifest
([airbnb/lottie-ios#2252)
- Codesign Lottie.xcframework
([airbnb/lottie-ios#2259)
- Add time remapping support to Core Animation rendering engine
([airbnb/lottie-ios#2286)
- Add official visionOS support to lottie-ios repo
([airbnb/lottie-ios#2287)
- lottie-spm now supports visionOS
([airbnb/lottie-spm#12)
- Adopt policy on minimum supported Swift / Xcode version, update
minimum versions to Swift 5.7 / Xcode 14.1
([airbnb/lottie-ios#2260)

#### Bug fixes

- Update LottieView to display placeholder using `overlay` instead of
`ZStack`
([airbnb/lottie-ios#2289)
- Fix issue where Core Animation rendering engine couldn't display last
frame of animation when paused
([airbnb/lottie-ios#2254)
- Do not create `DotLottieImageProvider` instance if there's no image
files
([airbnb/lottie-ios#2271)
- Mark DotLottieCache as Sendable
([airbnb/lottie-ios#2245)
- Fix issue where AnimationKeypath in SolidLayer could be incorrect
([airbnb/lottie-ios#2278)
- Fix issue where Repeater could be displayed incorrectly
([airbnb/lottie-ios#2276)
- Include dSYMs in xcframework build
([airbnb/lottie-ios#2284)
- Fix parsing issue, add support for DotLottieConfiguration in SwiftUI
LottieView
([airbnb/lottie-ios#2277)
- Fix issue where DotLottieImageProvider didn't handle base64 images
([airbnb/lottie-ios#2283)
- Fix issue where manually interpolated keyframes could animate
incorrectly
([airbnb/lottie-ios#2285)

**Full Changelog**:
airbnb/lottie-ios@4.3.4...4.4.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
iago849 pushed a commit to atteamapps/lottie-ios that referenced this pull request Feb 8, 2024
@calda @iago849
Update CI to build for visionOS (airbnb#2287)
26914cd
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Feb 22, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency airbnb/lottie-spm to from: "4.4.1" (#933)
4fe15e8 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.4.0"` -> `from: "4.4.1"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.4.1`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.1)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.0...4.4.1)

##### Bug fixes in 4.4.1

- Replace os check with canImport so classes are available on visionOS
([airbnb/lottie-ios#2294)
- Omit privacy manifest from source files in podspec
([airbnb/lottie-ios#2307)
- Fix crash in Main Thread rendering engine path interpolation
implementation
([airbnb/lottie-ios#2305)
- Fix warning from invalid character in Cocoapods resource bundle
identifier
([airbnb/lottie-ios#2317)
- Fix infinite loop when setting `LottieAnimationView.viewportFrame`
([airbnb/lottie-ios#2316)

##### New features in 4.4.0

- Add privacy manifest
([airbnb/lottie-ios#2252)
- Codesign Lottie.xcframework
([airbnb/lottie-ios#2259)
- Add time remapping support to Core Animation rendering engine
([airbnb/lottie-ios#2286)
- Add official visionOS support to lottie-ios repo
([airbnb/lottie-ios#2287)
- lottie-spm now supports visionOS
([airbnb/lottie-spm#12)
- Adopt policy on minimum supported Swift / Xcode version, update
minimum versions to Swift 5.7 / Xcode 14.1
([airbnb/lottie-ios#2260)

**Full Changelog**:
airbnb/lottie-ios@4.4.0...4.4.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 8, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency airbnb/lottie-spm to from: "4.4.2" (#994)
69daf5f 
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.4.1"` -> `from: "4.4.2"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.4.2`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.2)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.1...4.4.2)

##### Changes in 4.4.2

- Update minimum deployment target to iOS 13.0 / macOS 10.15
([airbnb/lottie-ios#2322)
- Add privacy manifest to lottie-spm repo
([airbnb/lottie-spm#23)
- Add visionOS support to Cocoapods podspec
([airbnb/lottie-ios#2348)
- Fix incorrect usage of `State(initialValue:)` in `LottieView`
([airbnb/lottie-ios#2357)
- Use correct version number when building XCFramework bundle
([airbnb/lottie-ios#2341)

##### New features in 4.4.0

- Add privacy manifest
([airbnb/lottie-ios#2252)
- Codesign Lottie.xcframework
([airbnb/lottie-ios#2259)
- Add time remapping support to Core Animation rendering engine
([airbnb/lottie-ios#2286)
- Add official visionOS support to lottie-ios repo
([airbnb/lottie-ios#2287)
- lottie-spm now supports visionOS
([airbnb/lottie-spm#12)
- Adopt policy on minimum supported Swift / Xcode version, update
minimum versions to Swift 5.7 / Xcode 14.1
([airbnb/lottie-ios#2260)

**Full Changelog**:
airbnb/lottie-ios@4.4.1...4.4.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 16, 2024
@cgrindel-self-hosted-renovate
chore(deps): update dependency airbnb/lottie-spm to from: "4.4.3" (#1017
23f5f74 
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.4.2"` -> `from: "4.4.3"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.4.3`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.3)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.2...4.4.3)

##### Bug fixes in 4.4.3

- Fix issue where animation size could be incorrect after loading async
animation
([airbnb/lottie-ios#2379)
- Update NSPrivacyAccessedAPITypeReasons in privacy manifest
([airbnb/lottie-ios#2380)
- Include animation duration when computing cost/complexity of Core
Animation time remapping
([airbnb/lottie-ios#2381)

##### New features in 4.4.0

- Add privacy manifest
([airbnb/lottie-ios#2252)
- Codesign Lottie.xcframework
([airbnb/lottie-ios#2259)
- Add time remapping support to Core Animation rendering engine
([airbnb/lottie-ios#2286)
- Add official visionOS support to lottie-ios repo
([airbnb/lottie-ios#2287)
- lottie-spm now supports visionOS
([airbnb/lottie-spm#12)
- Adopt policy on minimum supported Swift / Xcode version, update
minimum versions to Swift 5.7 / Xcode 14.1
([airbnb/lottie-ios#2260)

**Full Changelog**:
airbnb/lottie-ios@4.4.2...4.4.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thedrick thedrick thedrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@calda @thedrick