Adopt policy on minimum supported Swift / Xcode version, update minimum versions to Swift 5.7 / Xcode 14.1 #2260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calda
commented
Dec 14, 2023
| @@ -65,7 +65,7 @@ struct BezierPathKeyframe { | |||
| -> KeyframeGroup<BezierPathKeyframe> | |||
| { | |||
| guard | |||
| let cornerRadius = cornerRadius, | |||
There was a problem hiding this comment.
the linter automatically applied Swift 5.7 features after updating Package.swift to swift-tools-version: 5.7.
thedrick
approved these changes
Dec 14, 2023
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Jan 23, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | minor | `from: "4.3.4"` -> `from: "4.4.0"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.4.0`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.0) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.3.4...4.4.0) #### New features - Add privacy manifest ([airbnb/lottie-ios#2252) - Codesign Lottie.xcframework ([airbnb/lottie-ios#2259) - Add time remapping support to Core Animation rendering engine ([airbnb/lottie-ios#2286) - Add official visionOS support to lottie-ios repo ([airbnb/lottie-ios#2287) - lottie-spm now supports visionOS ([airbnb/lottie-spm#12) - Adopt policy on minimum supported Swift / Xcode version, update minimum versions to Swift 5.7 / Xcode 14.1 ([airbnb/lottie-ios#2260) #### Bug fixes - Update LottieView to display placeholder using `overlay` instead of `ZStack` ([airbnb/lottie-ios#2289) - Fix issue where Core Animation rendering engine couldn't display last frame of animation when paused ([airbnb/lottie-ios#2254) - Do not create `DotLottieImageProvider` instance if there's no image files ([airbnb/lottie-ios#2271) - Mark DotLottieCache as Sendable ([airbnb/lottie-ios#2245) - Fix issue where AnimationKeypath in SolidLayer could be incorrect ([airbnb/lottie-ios#2278) - Fix issue where Repeater could be displayed incorrectly ([airbnb/lottie-ios#2276) - Include dSYMs in xcframework build ([airbnb/lottie-ios#2284) - Fix parsing issue, add support for DotLottieConfiguration in SwiftUI LottieView ([airbnb/lottie-ios#2277) - Fix issue where DotLottieImageProvider didn't handle base64 images ([airbnb/lottie-ios#2283) - Fix issue where manually interpolated keyframes could animate incorrectly ([airbnb/lottie-ios#2285) **Full Changelog**: airbnb/lottie-ios@4.3.4...4.4.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
iago849
pushed a commit
to atteamapps/lottie-ios
that referenced
this pull request
Feb 8, 2024
…um versions to Swift 5.7 / Xcode 14.1 (airbnb#2260)
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Feb 22, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch | `from: "4.4.0"` -> `from: "4.4.1"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.4.1`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.1) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.0...4.4.1) ##### Bug fixes in 4.4.1 - Replace os check with canImport so classes are available on visionOS ([airbnb/lottie-ios#2294) - Omit privacy manifest from source files in podspec ([airbnb/lottie-ios#2307) - Fix crash in Main Thread rendering engine path interpolation implementation ([airbnb/lottie-ios#2305) - Fix warning from invalid character in Cocoapods resource bundle identifier ([airbnb/lottie-ios#2317) - Fix infinite loop when setting `LottieAnimationView.viewportFrame` ([airbnb/lottie-ios#2316) ##### New features in 4.4.0 - Add privacy manifest ([airbnb/lottie-ios#2252) - Codesign Lottie.xcframework ([airbnb/lottie-ios#2259) - Add time remapping support to Core Animation rendering engine ([airbnb/lottie-ios#2286) - Add official visionOS support to lottie-ios repo ([airbnb/lottie-ios#2287) - lottie-spm now supports visionOS ([airbnb/lottie-spm#12) - Adopt policy on minimum supported Swift / Xcode version, update minimum versions to Swift 5.7 / Xcode 14.1 ([airbnb/lottie-ios#2260) **Full Changelog**: airbnb/lottie-ios@4.4.0...4.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 8, 2024
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch | `from: "4.4.1"` -> `from: "4.4.2"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.4.2`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.2) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.1...4.4.2) ##### Changes in 4.4.2 - Update minimum deployment target to iOS 13.0 / macOS 10.15 ([airbnb/lottie-ios#2322) - Add privacy manifest to lottie-spm repo ([airbnb/lottie-spm#23) - Add visionOS support to Cocoapods podspec ([airbnb/lottie-ios#2348) - Fix incorrect usage of `State(initialValue:)` in `LottieView` ([airbnb/lottie-ios#2357) - Use correct version number when building XCFramework bundle ([airbnb/lottie-ios#2341) ##### New features in 4.4.0 - Add privacy manifest ([airbnb/lottie-ios#2252) - Codesign Lottie.xcframework ([airbnb/lottie-ios#2259) - Add time remapping support to Core Animation rendering engine ([airbnb/lottie-ios#2286) - Add official visionOS support to lottie-ios repo ([airbnb/lottie-ios#2287) - lottie-spm now supports visionOS ([airbnb/lottie-spm#12) - Adopt policy on minimum supported Swift / Xcode version, update minimum versions to Swift 5.7 / Xcode 14.1 ([airbnb/lottie-ios#2260) **Full Changelog**: airbnb/lottie-ios@4.4.1...4.4.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
cgrindel-self-hosted-renovate bot
added a commit
to cgrindel/rules_swift_package_manager
that referenced
this pull request
Apr 16, 2024
) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch | `from: "4.4.2"` -> `from: "4.4.3"` | --- ### Release Notes <details> <summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary> ### [`v4.4.3`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.3) [Compare Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.2...4.4.3) ##### Bug fixes in 4.4.3 - Fix issue where animation size could be incorrect after loading async animation ([airbnb/lottie-ios#2379) - Update NSPrivacyAccessedAPITypeReasons in privacy manifest ([airbnb/lottie-ios#2380) - Include animation duration when computing cost/complexity of Core Animation time remapping ([airbnb/lottie-ios#2381) ##### New features in 4.4.0 - Add privacy manifest ([airbnb/lottie-ios#2252) - Codesign Lottie.xcframework ([airbnb/lottie-ios#2259) - Add time remapping support to Core Animation rendering engine ([airbnb/lottie-ios#2286) - Add official visionOS support to lottie-ios repo ([airbnb/lottie-ios#2287) - lottie-spm now supports visionOS ([airbnb/lottie-spm#12) - Adopt policy on minimum supported Swift / Xcode version, update minimum versions to Swift 5.7 / Xcode 14.1 ([airbnb/lottie-ios#2260) **Full Changelog**: airbnb/lottie-ios@4.4.2...4.4.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2197 I proposed a new policy for what minimum Swift / Xcode version Lottie should support.
We didn't hear any negative feedback, so it seems reasonable to adopt this as our "official" policy.
This PR adds this policy to the README, and updates the minimum supported versions to Swift 5.7.1 / Xcode 14.1 (the current minimum version supported by the App Store).