Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where animation size could be incorrect after loading async animation #2379

Merged
merged 3 commits into from Apr 15, 2024

Conversation

calda
Copy link
Member

@calda calda commented Apr 15, 2024

This PR fixes an issue where the view's size could be incorrect after loading an async animation.

I believe this issue was introduced by #2289, when we changed the lifecycle of the LottieAnimationView. Previously it was only added to the view hierarchy after the animation finished loading. Now it's always present, so can have an intrinsic size of zero if measured before the async animation finishes loading.

Here's the sample code I added to test this case. The async case was broken before. Now both work as expected.

VStack {
  LottieView(animation: .named("Samples/LottieLogo1"))
    .intrinsicSize()
    .looping()

  Text("intrinsic size")
}

VStack {
  LottieView {
    try await Task.sleep(for: .seconds(1))
    return LottieAnimation.named("Samples/LottieLogo1")
  }
  .intrinsicSize()
  .looping()

  Text("intrinsic size, async")
}

Before

Screenshot 2024-04-15 at 12 09 25 PM

After

Screenshot 2024-04-15 at 12 09 50 PM

Copy link
Contributor

@brynbodayle brynbodayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@calda calda merged commit 52b22e8 into master Apr 15, 2024
15 checks passed
@calda calda deleted the cal--intrinsic-size-fix branch April 15, 2024 20:33
cgrindel-self-hosted-renovate bot added a commit to cgrindel/rules_swift_package_manager that referenced this pull request Apr 16, 2024
)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [airbnb/lottie-spm](https://togithub.com/airbnb/lottie-spm) | patch |
`from: "4.4.2"` -> `from: "4.4.3"` |

---

### Release Notes

<details>
<summary>airbnb/lottie-spm (airbnb/lottie-spm)</summary>

###
[`v4.4.3`](https://togithub.com/airbnb/lottie-spm/releases/tag/4.4.3)

[Compare
Source](https://togithub.com/airbnb/lottie-spm/compare/4.4.2...4.4.3)

##### Bug fixes in 4.4.3

- Fix issue where animation size could be incorrect after loading async
animation
([airbnb/lottie-ios#2379)
- Update NSPrivacyAccessedAPITypeReasons in privacy manifest
([airbnb/lottie-ios#2380)
- Include animation duration when computing cost/complexity of Core
Animation time remapping
([airbnb/lottie-ios#2381)

##### New features in 4.4.0

- Add privacy manifest
([airbnb/lottie-ios#2252)
- Codesign Lottie.xcframework
([airbnb/lottie-ios#2259)
- Add time remapping support to Core Animation rendering engine
([airbnb/lottie-ios#2286)
- Add official visionOS support to lottie-ios repo
([airbnb/lottie-ios#2287)
- lottie-spm now supports visionOS
([airbnb/lottie-spm#12)
- Adopt policy on minimum supported Swift / Xcode version, update
minimum versions to Swift 5.7 / Xcode 14.1
([airbnb/lottie-ios#2260)

**Full Changelog**:
airbnb/lottie-ios@4.4.2...4.4.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
dus7 added a commit to duckduckgo/iOS that referenced this pull request Apr 19, 2024
Fixes (https://github.com/airbnb/lottie-spm/releases/tag/4.4.3):
* Fix issue where animation size could be incorrect after loading async animation (airbnb/lottie-ios#2379)
* Update NSPrivacyAccessedAPITypeReasons in privacy manifest (airbnb/lottie-ios#2380)
* Include animation duration when computing cost/complexity of Core Animation time remapping (airbnb/lottie-ios#2381)
@dus7 dus7 mentioned this pull request Apr 19, 2024
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants