Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MvRx at Airbnb utilities #112

Open
filipwiech opened this issue Oct 4, 2018 · 11 comments
Open

MvRx at Airbnb utilities #112

filipwiech opened this issue Oct 4, 2018 · 11 comments

Comments

@filipwiech
Copy link

Hi,

Looking through the wiki, more specifically "MvRx at Airbnb" page, I found some things that look really useful and convenient, namely the Fragments/MvRxFragments class for easy registering and creating fragments (even without a need for creating our own activity) with optional cross-module access, showFragment/showModal for fragment navigation and finally MvRxLauncher for starting fragments from launcher shortcuts. Is there any possibility for open sourcing those functionalities and sharing them with the community?

I understand that perhaps this is out of scope for the core MvRx, but maybe it could be released as an extension module?

@elihart
Copy link
Contributor

elihart commented Oct 4, 2018

I would like to release this as a separate module. This code is not as stable - I would like to keep developing the API's and develop it more internally first though. Maybe sometime next year though.

If you're really interested we could probably share it as a gist for now

@qbait
Copy link

qbait commented Oct 4, 2018

Gist would be great. Thanks @elihart for your work!

@filipwiech
Copy link
Author

filipwiech commented Oct 8, 2018

@elihart Thank you for the quick response, I'm really looking forward to this! In the meantime a gist of an early version would be very appreciated.

@filipwiech
Copy link
Author

Hi, is there any update on this (module release and/or gist snippets)?

@elihart
Copy link
Contributor

elihart commented Apr 4, 2019

No updates yet, but still something we would like to do in the future

@gpeal
Copy link
Collaborator

gpeal commented Aug 31, 2019

@elihart is there anything still there that would be worth open sourcing as part of this issue?

@elihart
Copy link
Contributor

elihart commented Oct 21, 2019

We are working on a new inter-module navigation system that can potentially be open sourced, it would be great to release if possible

@Zoha131
Copy link

Zoha131 commented Nov 26, 2019

@elihart is there any update on this issue? Can we expect any update by March 2020?

@elihart
Copy link
Contributor

elihart commented Nov 26, 2019

From the comment above asking for this:

  • MvRxLauncher is actively being added in another PR. it is already working and visible in that branch and will be released as an alpha release soon
  • showFragment/showModal are not really anything. They are just functions to a base Fragment class that take a fragment as an argument and show it. The modal vs fragment thing is just a pattern we use to change the entry animation, but you can customize that however you want.
  • The navigation system I recently mentioned is not built yet. I can share a gist of the older MvRxFragments soon

@elihart
Copy link
Contributor

elihart commented Dec 5, 2019

Here is an example of a system for loading Fragments: https://gist.github.com/elihart/74e465676ff6663729f52690661e37e0

It has a few MvRx specific things (like how arguments are handled), but for the most part stands alone from MvRx (which is why it's not part of this library).

This is an incomplete example, it assumes you have base classes for your fragment and activities which are not provided, but which you should be able to figure out easily enough

@jpventura
Copy link
Contributor

@elihart internally at Airbnb, will you keep this loading system for also refactor to Jetpack Navigation? #351

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants