Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The wiki is contradicting itself #99

Closed
jQrgen opened this issue Sep 26, 2018 · 2 comments
Closed

The wiki is contradicting itself #99

jQrgen opened this issue Sep 26, 2018 · 2 comments

Comments

@jQrgen
Copy link

jQrgen commented Sep 26, 2018

Both BaseMvRxFragment and BaseMvRxActivity says the base activity should "only extend this".

ref: https://github.com/airbnb/MvRx/wiki/Integrating-MvRx-In-Your-App
screen shot 2018-09-26 at 14 33 14

@gpeal
Copy link
Collaborator

gpeal commented Sep 26, 2018

Ah, it should just say Fragment instead of Activity. Fixed. Thanks!

@gpeal gpeal closed this as completed Sep 26, 2018
@jQrgen
Copy link
Author

jQrgen commented Sep 27, 2018

I find typos here and there too. Can the wiki be community edited?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants