[a11y] Set aria-label explicitly #1594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Mar 21, 2019
src/components/DateInput.jsx
Outdated
| @@ -217,7 +220,7 @@ class DateInput extends React.PureComponent { | |||
| focused && styles.DateInput_input__focused, | |||
| disabled && styles.DateInput_input__disabled, | |||
| )} | |||
| aria-label={placeholder} | |||
| aria-label={ariaLabel} | |||
There was a problem hiding this comment.
we'd need to retain the ariaLabel || placeholder fallback here, otherwise this is a breaking change.
There was a problem hiding this comment.
Ah, got it. Didn't think about the breaking nature of this. I'll want some way to not have any aria-label field, so what do you think about having a ternary like: ariaLabel === undefined ? placeholder : null
There was a problem hiding this comment.
I’d do : undefined, but that looks fine to me!
There was a problem hiding this comment.
Yeah, I goofed the example a bit. I used ariaLabel as the second case in the ternary, it shouldn't have been null.
ljharb
approved these changes
Mar 21, 2019
backwardok
approved these changes
Mar 21, 2019
|
@backwardok @ljharb Thanks for the thorough review and good comments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR would supersede #1590.
Currently the
aria-labelof the date pickerinputfield is being set with the value of theplaceholder. This seems to be almost always the wrong choice, as anaria-labelis totally different from a placeholder. This PR makes it so you can explicitly set thearia-labelof the input fields and theplaceholderis no longer used for that attribute.