Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Merge pull request #1758 from airbnb/nora--remove-direct-imports-of-css" #1818

Merged
merged 1 commit into from
Oct 1, 2019
Merged

Revert "Merge pull request #1758 from airbnb/nora--remove-direct-imports-of-css" #1818

merged 1 commit into from
Oct 1, 2019

Conversation

noratarano
Copy link
Contributor

@noratarano noratarano commented Oct 1, 2019 •
edited
Loading

Summary

Reverts #1758, which "fixed" the imports of css to use the injected prop rather than directly importing from react-with-styles. Unfortunately, this broke inline styles for RTL, which were not expected to be auto-transformed by the aphrodite interface.

In other words, react-dates is RTL-compatible, but does not implement RTL through the react-with-styles interface, so #1758 broke RTL for react-dates completely when used with the aphrodite interface.

Followup

In a followup, we'll have to update this library to rely on the css prop, but it will take more work than that PR anticipated.

Reviewers

@TaeKimJR @ljharb @joeuy @lencioni @majapw @caseklim

Revert "Merge pull request #1758 from airbnb/nora--remove-direct-impo…
08e9079 
…rts-of-css"

This reverts commit 3e66eba, reversing
changes made to 8c0ba98.
@noratarano noratarano added semver-major: breaking change A non-backwards-compatible change; anything that breaks code - including adding a peerDep. semver-patch: fixes/refactors/etc Anything that's not major or minor. and removed semver-major: breaking change A non-backwards-compatible change; anything that breaks code - including adding a peerDep. labels Oct 1, 2019
@noratarano noratarano merged commit fd1e903 into master Oct 1, 2019
@noratarano noratarano deleted the nora--revert-css-prop branch October 1, 2019 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noratarano @ljharb