Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #1758 from airbnb/nora--remove-direct-imports-of-css" #1818

Merged
merged 1 commit into from Oct 1, 2019

Conversation

@noratarano
Copy link
Contributor

commented Oct 1, 2019

Summary

Reverts #1758, which "fixed" the imports of css to use the injected prop rather than directly importing from react-with-styles. Unfortunately, this broke inline styles for RTL, which were not expected to be auto-transformed by the aphrodite interface.

In other words, react-dates is RTL-compatible, but does not implement RTL through the react-with-styles interface, so #1758 broke RTL for react-dates completely when used with the aphrodite interface.

Followup

In a followup, we'll have to update this library to rely on the css prop, but it will take more work than that PR anticipated.

Reviewers

@TaeKimJR @ljharb @joeuy @lencioni @majapw @caseklim

…rts-of-css"

This reverts commit 3e66eba, reversing
changes made to 8c0ba98.
@ljharb
ljharb approved these changes Oct 1, 2019
@noratarano noratarano merged commit fd1e903 into master Oct 1, 2019
4 checks passed
4 checks passed
Tidelift Dependencies checked
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 11.246%
Details
@noratarano noratarano deleted the nora--revert-css-prop branch Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.