Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is airbnb still on this project? #1280

Closed
henrikra opened this issue Apr 28, 2017 · 24 comments
Closed

Is airbnb still on this project? #1280

henrikra opened this issue Apr 28, 2017 · 24 comments

Comments

@henrikra
Copy link

I feel like this library has been abandoned since the collaborators are not fixing even the critical bugs. There is 502 issues and 37 prs open. This is not normal. There are at least two very critical bugs caused this library to crash for many users. They are these: #271 #1227

Could you please tell if you are not going to do this project very often? If yes could you consider adding collaborators who are actually active and who do reviews prs and make new releases

@hrastnik
Copy link

It's gets worse... The official RN docs recommends this component since their MapView component is depracated and supports only iOS.

Source: https://facebook.github.io/react-native/docs/mapview.html

@tim-phillips
Copy link

A software engineer at airbnb committed to master 24 days ago.

screen shot 2017-04-28 at 7 26 59 pm

https://github.com/airbnb/react-native-maps/commits/master

@henrikra
Copy link
Author

@babenzele Yeah that is the problem :D

@tim-phillips
Copy link

What's the problem? 24 days too long for comfort? OSS projects don't fix themselves, take a dive in there and submit a PR.

@Exilz
Copy link

Exilz commented Apr 30, 2017

The problem is not the lack of commit for airbnb themselves. As you said, community can take care of this project and fix the most important stuff. We don't expect them to dedicate an employee's time adding feature to a community plugin.
As @henrikra said, the pull requests aren't supervised enough. Very interesting changes have been submitted ages ago and still nothing happened.

@tim-phillips
Copy link

Hmm, let's try get some good ones merged. Could you link some of the better ones?

@henrikra
Copy link
Author

henrikra commented May 1, 2017

@babenzele All PR's related to crashes are priority one in my opinion. Since if the maps is crashing often the features does not matter :)

@tim-phillips
Copy link

Only one PR comes up when I search "crash" (#1273) and it was opened 5 days ago.

https://github.com/airbnb/react-native-maps/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20crash

@alreadysabbir
Copy link

Critical PR like #1249 #1193 #1226 #1200 is not yet merged!
Please add more collaborator at least!

@alreadysabbir
Copy link

Not even docs improvement PR 😞

@henrikra
Copy link
Author

henrikra commented May 2, 2017

@babenzele For example #1287 this issue is making whole map crash on RN 0.44

@jeveloper
Copy link

@lelandrichardson Leland, would you consider moving the project to community or add collaborators . Thank you

@gshotwell
Copy link

+1

@Falconerd
Copy link

Falconerd commented May 3, 2017

I was having huge issues getting this to work reliably across both platforms. I ended up using these versions:

react-native@0.42.3
react-native-maps@0.13.0

Hopefully that helps someone.

@kelset
Copy link

kelset commented May 3, 2017

I have it working properly with RN 0.43, but can't figure out a way to make it work with 0.44.
I agree on the more collabs need.

(To give a glimmer of hope, a while back Leland told me that they were preparing a huge release for RNMaps but I can't find the tweet anymore)

@james2406
Copy link

james2406 commented May 5, 2017

It looks like a few commits were made to the master branch, which should fix the 0.44 issue 4b861c9

@felipecsl
Copy link
Contributor

[Airbnb engineer here]
Indeed we're very resource constrained right now and have not given this library the attention it needs/deserves. I'll help triaging issues/PRs in the next couple days and we'll look into adding more contributors soon. Please bear with us in the meantime 😄

@jeveloper
Copy link

Thanks @felipecsl , appreciate you letting us know and thanks to AirBnB

btw , the current committs in the past 24 hours resolved a breaking problem for RN 44, any chance you can tag a version and push it up to npm , that would be great.

@felipecsl
Copy link
Contributor

@christopherdro it seems like you already uploaded 0.15.0 to next 4 days ago? I just promoted that to latest!

@EricPKerr
Copy link

EricPKerr commented Aug 29, 2017

@felipecsl @lelandrichardson This deserves to have a much larger discussion, but I feel like this issue should be re-opened. There are a dozen issues that mention initialRegion,region, and onRegionChange alone, and they've become noticeably more problematic with onMapReady hacks all over the place.

This should be moved to react-native-community (or even RN core) so more people can openly contribute and make this better. It's too critical of a project to not have more active core members triaging Issues and Pull Requests.

@felipecsl
Copy link
Contributor

felipecsl commented Aug 29, 2017

@EricPKerr reopening this issue will not help with fixing those problems you mentioned. We're happy to add more contributors to the project and/or move it to a different org (eg.: react-native-community, as you suggested). If anyone is familiar with the code, is using it in production and is committed to maintaining/improving this, please step forward and we'll be happy to work with you to add as maintainers. If you prefer moving it, I can help with that too!

@alvelig
Copy link
Contributor

alvelig commented Dec 5, 2017

@felipecsl ME! (stepping forward) At least iOS is familiar to me. And I am using it for production in several apps.

@felipecsl
Copy link
Contributor

@alvelig the current plan is to move this repo to the react-community org. We're waiting on someone with enough permissions to help with that transition.

@sasan-ebrahimi

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests