-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is airbnb still on this project? #1280
Comments
It's gets worse... The official RN docs recommends this component since their MapView component is depracated and supports only iOS. Source: https://facebook.github.io/react-native/docs/mapview.html |
A software engineer at airbnb committed to master 24 days ago. |
@babenzele Yeah that is the problem :D |
What's the problem? 24 days too long for comfort? OSS projects don't fix themselves, take a dive in there and submit a PR. |
The problem is not the lack of commit for airbnb themselves. As you said, community can take care of this project and fix the most important stuff. We don't expect them to dedicate an employee's time adding feature to a community plugin. |
Hmm, let's try get some good ones merged. Could you link some of the better ones? |
@babenzele All PR's related to crashes are priority one in my opinion. Since if the maps is crashing often the features does not matter :) |
Only one PR comes up when I search "crash" (#1273) and it was opened 5 days ago. https://github.com/airbnb/react-native-maps/pulls?utf8=%E2%9C%93&q=is%3Apr%20is%3Aopen%20crash |
Not even docs improvement PR 😞 |
@babenzele For example #1287 this issue is making whole map crash on RN 0.44 |
@lelandrichardson Leland, would you consider moving the project to community or add collaborators . Thank you |
+1 |
I was having huge issues getting this to work reliably across both platforms. I ended up using these versions:
Hopefully that helps someone. |
I have it working properly with RN 0.43, but can't figure out a way to make it work with 0.44. (To give a glimmer of hope, a while back Leland told me that they were preparing a huge release for RNMaps but I can't find the tweet anymore) |
It looks like a few commits were made to the master branch, which should fix the 0.44 issue 4b861c9 |
[Airbnb engineer here] |
Thanks @felipecsl , appreciate you letting us know and thanks to AirBnB btw , the current committs in the past 24 hours resolved a breaking problem for RN 44, any chance you can tag a version and push it up to npm , that would be great. |
@christopherdro it seems like you already uploaded 0.15.0 to next 4 days ago? I just promoted that to latest! |
@felipecsl @lelandrichardson This deserves to have a much larger discussion, but I feel like this issue should be re-opened. There are a dozen issues that mention This should be moved to react-native-community (or even RN core) so more people can openly contribute and make this better. It's too critical of a project to not have more active core members triaging Issues and Pull Requests. |
@EricPKerr reopening this issue will not help with fixing those problems you mentioned. We're happy to add more contributors to the project and/or move it to a different org (eg.: |
@felipecsl ME! (stepping forward) At least iOS is familiar to me. And I am using it for production in several apps. |
@alvelig the current plan is to move this repo to the |
I feel like this library has been abandoned since the collaborators are not fixing even the critical bugs. There is 502 issues and 37 prs open. This is not normal. There are at least two very critical bugs caused this library to crash for many users. They are these: #271 #1227
Could you please tell if you are not going to do this project very often? If yes could you consider adding collaborators who are actually active and who do reviews prs and make new releases
The text was updated successfully, but these errors were encountered: