fixed iOS google MapView.onMarkerPress not receiving the marker identifier #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
monholm
added a commit
to monholm/react-native-maps
that referenced
this pull request
Oct 7, 2021
See react-native-maps#1741. I'm not really sure if it fixed anything back then, or just helped making it easier to access the data of the nativeEvent. Either way, this will never be called today, as the consumer-provided prop will override this, as the consumer props are spread AFTER this is passed, as opposed to back when the fix was introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On iOS, if the map provider is 'google', the onMarkerPress callback of the MapView would be called when clicking a marker but the identifier of the marker would not be available.
I noticed that the "onChange" function was successfully being called from native to JS so I mimic-ed the "onChange" function of the MapView everywhere and applied this to the "onMarkerPress" function.
I don't fully understand how the objective-C <=> JS binding works, so this might not be the best way to fix the problem, but it's the cleanest I could think of.
Note: this fix is a workaround to the issue that MapView.Marker.onPress is not being called if the provider is 'google':
#1721