Fix accessibilityComponentType crash #49
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
DynamicFromMap
internally usesSimplePool
object to recycle dynamic prop objects. But the pool is not multi-thread safe. BeforeaccessibilityComponentType
prop was added, the only dynamic props are size props such asleft
,paddingVertical
,marginTop
and so on. These props are only accessed from the layout thread so the pool works fine. The newaccessibilityComponentType
prop is accessed from UI thread, so now two threads can access the pool object and caused random errors. This PR make the pool object thread local to avoid synchronization. After this change there are two pool objects created in the process.Test Plan
Tested RNTester app and didn't notice anything.
Code Review
@lelandrichardson @gpeal