Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TooltipWithBounds bug #767

Closed
terpimost opened this issue Jul 23, 2020 · 5 comments · Fixed by #828 or #857
Closed

TooltipWithBounds bug #767

terpimost opened this issue Jul 23, 2020 · 5 comments · Fixed by #828 or #857

Comments

@terpimost
Copy link

I think in TooltipWithBounds the line unstyled={unstyled} should be deleted because we checking styles in the style property
image

With that line if I use unstyled TooltipWithBounds no position will be set because inside ToolTip no styles will be set at all because they should be taken from TooltipWithBounds.

https://github.com/hshoff/vx/blob/8ede587c3cc47d56736bc58f99e3d8a94a1e0850/packages/vx-tooltip/src/tooltips/TooltipWithBounds.tsx#L53

@williaster
Copy link
Collaborator

@terpimost sorry for the delay, agree this is likely a bug! would happily review a PR 😁

@heyanurag
Copy link
Contributor

Hey @williaster may I remove the line? I'm new to open-source and I think I can do this!

@terpimost
Copy link
Author

@singhanurag05 go ahead and remove the line

@heyanurag
Copy link
Contributor

Hi @terpimost can you please check PR #828 I did it.

@terpimost
Copy link
Author

terpimost commented Oct 1, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment