-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TooltipWithBounds positioning #828
Conversation
Pull Request Test Coverage Report for Build 116
💛 - Coveralls |
@williaster Was this correct or not? Did I do something wrong? Please reply. |
hey @singhanurag05 thanks for the fix! just to check I pulled this branch and played with it locally, then realized that the ideal solution is a bit more complicated. I opened #831 with what I think is the needed fix. If you'd like to implement this yourself for more coding experience I'm happy to close it if you make those updates! Otherwise we can close this PR and use that one. |
I had thought of the exact same thing! please let me do this @williaster |
@singhanurag05 great! One comment on my changes: let's not set |
@williaster Sorry I didn't get you. Can you please explain? |
In my PR I made the change to remove so if you mirror the changes in my PR, I just meant to not make that change (i.e., leave |
Absolutely yes! i'll make the changes in sometime. Thanks for the help! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! had one last suggestion but then I think this is good to go.
Co-authored-by: Chris Williams <williaster@users.noreply.github.com>
Thank you! Hope to contribute further. |
🐛 Bug Fix
Please correct me if I did something wrong as I am new to Open Source.