fix(tooltip): correct positioning when unstyled is applied #831
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This PR
unstyled
onTooltipWithBounds
breaks positioning because it is passed toTooltip
, which then doesn't respect thestyle
prop which includes the needed offsetunstyled
is set on eitherTooltip
orTooltipWithBounds
, lib consumers must also minimally set.visx-tooltip { position: absolute; }
themselves in order for the tooltips to be correctly positioned since they rely onabsolute
positioning.position: absolute
fromdefaultStyles
, and always setting it (along with the positional offset)Testing
Verified in
/tooltip
demo that tooltip is correctly positioned whenunstyled
is set for all combinationsportalboundary detection+portalboundary detection+ portal@hshoff @kristw @singhanurag05