Bug: LinePath doesn't connect if value is 0

[thienanle]

[hshoff]

Hi @thienanle thanks for checking out vx!

<LinePath /> accepts a defined prop which is a function which defaults to d => y(d) && x(d): https://github.com/hshoff/vx/blob/master/packages/vx-shape/src/shapes/LinePath.js#L27 in this case y(d) returns 0 which evaluates to false in javascript

If you pass in defined={d => true} it should work.

Maybe this is a bad default and we should match the d3 default of () => true: https://github.com/d3/d3-shape#line_defined

[thienanle]

@hshoff thanks for making VX!

Yes I'd agree matching D3's default would be better, but this works for me for now. Thanks for the fast response.

[hshoff]

Will update it in the v0.0.131 release. Tracking here #100