Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[xychart] x/yscale config for zero/nice has no effect #986

Closed
Janpot opened this issue Jan 3, 2021 · 3 comments · Fixed by #987
Closed

[xychart] x/yscale config for zero/nice has no effect #986

Janpot opened this issue Jan 3, 2021 · 3 comments · Fixed by #987

Comments

@Janpot
Copy link
Contributor

Janpot commented Jan 3, 2021

Noticed that nice and zero options for the XYChart scales don't have any effect. It's as if they are ignored:

      <XYChart
        xScale={{ type: 'time' }}
        yScale={{ type: 'linear', zero: true, nice: true }}
        height={height}
      >

Can also be observed in this modified example

@williaster
Copy link
Collaborator

Thanks again for reporting this and for the fix! 🙌

@Janpot
Copy link
Contributor Author

Janpot commented Jan 4, 2021

@williaster Great. I also sort of need custom Glyph for Tooltip. Would you accept a PR that adds a renderprop to Tooltip? renderGlyph or something.

@williaster
Copy link
Collaborator

@Janpot yes! that was originally scoped for the MVP launch but didn't make the cut. I've created an issue to track #988, and would be happy to review a PR 👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants