Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

airbyte/normalization dev version should available in dockerhub. #1190

Closed
cgardens opened this issue Dec 4, 2020 · 3 comments
Closed

airbyte/normalization dev version should available in dockerhub. #1190

cgardens opened this issue Dec 4, 2020 · 3 comments
Assignees
@cgardens
Labels
priority/high High priority type/bug Something isn't working
Milestone
v0.8.0

Comments

@cgardens
Copy link
Contributor

cgardens commented Dec 4, 2020

Expected Behavior

  • when running the dev version of the app, i should be able to do so without having to build any of the images locally.

Current Behavior

  • failures because airbyte/normalization:dev is not pushed by the CI to docker hub like the other core images are.
@cgardens cgardens added the type/bug Something isn't working label Dec 4, 2020
@cgardens cgardens added this to the v0.8.0 milestone Dec 4, 2020
@cgardens cgardens added the priority/high High priority label Dec 4, 2020
@michel-tricot michel-tricot mentioned this issue Dec 4, 2020
Closed
@cgardens
Copy link
Contributor Author

cgardens commented Dec 4, 2020

we should use a versioned base-normalization image, not use the dev one no?

from @sherifnada

Good question. 2 paths here:

  1. base-normalization uses the same version numbers that webapp, server, etc use which is defined in .env file. this means we are thinking of normalization as a "core" feature. In which case the dev version of it should be pushed when we push the dev version of the core images and it should be released as part of release_version.
  2. we treat it like a connector and upgrade its image each time we update it.

@sherifnada - does this capture your thoughts?

@cgardens cgardens self-assigned this Dec 4, 2020
@cgardens cgardens mentioned this issue Dec 4, 2020
Closed
@cgardens
Copy link
Contributor Author

cgardens commented Dec 4, 2020

Discussed during stand up. going with option 1.

@cgardens
Copy link
Contributor Author

cgardens commented Dec 5, 2020

closed by #1209

@cgardens cgardens closed this as completed Dec 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cgardens cgardens

Labels
priority/high High priority type/bug Something isn't working
Projects
None yet
Milestone
v0.8.0
Development

Successfully merging a pull request may close this issue.

Version Normalization as if it were part of core airbytehq/airbyte
1 participant
@cgardens