Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data missing in Google Ads latest vrsion for ad_group_ad_report #12999

Closed
Tracked by #11758
marcosmarxm opened this issue May 18, 2022 · 12 comments · Fixed by #13423
Closed
Tracked by #11758

Data missing in Google Ads latest vrsion for ad_group_ad_report #12999

marcosmarxm opened this issue May 18, 2022 · 12 comments · Fixed by #13423
Assignees

Comments

@marcosmarxm
Copy link
Member

Environment

  • Airbyte version: 0.35.61-alpha
  • OS Version / Instance: GCP
  • Deployment: Docker
  • Source Connector and version: Google Ads 0.1.37
  • Destination Connector and version: Snowflake 0.4.24
  • Step where error happened: Deploy / Sync job / Setup new connection / Update connector / Upgrade Airbyte

Current Behavior

Latest version of Google Ads is not bringing all campaigns for ad_group_ad_report
This is what Google return from querying directly the data:

  • Responsive search ad
  • Non-skipable in-stream ad
  • Discovery ad

But ad_group_ad_report only brings campaign of type

  • Reponsive search ad

There isn't any info in docs or Google changelog saying something about filtering data from reports.
Using Version with Google v8 brings all records and campaigns.

Expected Behavior

Tell us what should happen.

Logs

Steps to Reproduce

Are you willing to submit a PR?

Remove this with your answer.

@marcosmarxm
Copy link
Member Author

One comparative is: ad_group_ad_report and ad_group_ads have the same table reference but they bring different campaigns.

@tinomerl
Copy link
Contributor

tinomerl commented May 23, 2022

@marcosmarxm we also encountered this behaviour. i replicated the raw http calls and found out that data goes "missing" when the field segments.keyword.ad_group_criterion added in #9310 is in the call. Data is then missing on the campaign level. The missing campaigns seem to be retargeting campaigns.

downgrading the google ads connector to 0.1.34 fixes it for now.

@davydov-d
Copy link
Collaborator

Hi @marcosmarxm have you tried reproducing the issue with version 0.1.39? I tried to reproduce it on versions 0.1.23 (api v8), 0.1.34 and 0.1.39 and the data was not missing. The one thing worth mentioning is that we do not have ads of types Non-skipable in-stream and Discovery in our test account as they are quite expensive. Instead, we have "Responsive search" ad and "Responsive display ad". I'd be grateful if you provide me with more details on how I can reproduce the issue or give me the access to the account where it persists. Another option is to gain approval for running ad types from report

@tinomerl
Copy link
Contributor

Hey @davydov-d,

i'm sadly not marcosmarxm but i tried replicating the issue with 0.1.39. and it persisted. see the attached screenshots.

image
image

i dug a bit more in this ad account. the missing campaigns have the campaign type display network. and the ads are responsive display ads. Hope that helps.

@davydov-d
Copy link
Collaborator

@ycherniaiev could you please support me and fill in our test account with the data provided by @tinomerl ? that would give me another try to reproduce the issue

@tinomerl
Copy link
Contributor

@davydov-d i'm sorry to disappoint you, but that won't be possible. The data shown in my screenshots is from a customer of the place i'm working at in our current test env, that's why it's redacted. i just wanted to chime into the discusion to help you guys a bit out out. i think you will have to wait until @marcosmarxm can give you access to the data. sorry i can't be of any more help.

@ycherniaiev
Copy link
Contributor

@davydov-d Discovery and non-skippable test ads are running.Will inform you when we get conversions

@davydov-d
Copy link
Collaborator

@tinomerl thanks to you and @ycherniaiev I did reproduce it!
you were completely right about the segments.keyword.ad_group_criterion field, more on that in the attached PR

@marcosmarxm
Copy link
Member Author

Other user is having problem with reports: #13425

@tinomerl
Copy link
Contributor

tinomerl commented Jun 2, 2022

Hey @davydov-d, thanks for the info. glad i could help you. 👍

@bigdatawonders
Copy link

Other user is having problem with reports: #13425

Maybe you could also mark this as a critical bug?
seems it has been solved for 15 days already.

@bigdatawonders
Copy link

Is there a quick solution? Maybe to revert to older source version or this is related to google api changes??
Thanks!!!

davydov-d added a commit that referenced this issue Jun 2, 2022
…tream (#13423)

* #12999 drop schema field that filters out the data from stream

* #12999 up changelog

* #12999 source google ads: add note to the doc

* auto-bump connector version

Co-authored-by: Octavia Squidington III <octavia-squidington-iii@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants