Source Google Ads: drop schema field that filters out the data from stream

[davydov-d]

What

Fix to return the missing data in one of the streams

How

Drop one of the fields that filters out the data

---

Once the field segments.keyword.ad_group_criterion was introduced in the ad_group_ad_report stream, we got couple of missing data reports.

What we have in the UI:

what we have in the stream (cost_micros aggregated):

what we have in the stream after dropping the field (cost_micros aggregated):

This behavior is explained in a tiny paragraph deep inside the Google Ads docs.
On one hand, this is legitimate behavior (the field is also present in the migration from Adwords guide), on the other this is very unobvious and data is lost when you use the connector of version 0.1.36-39 compared to other versions.

[davydov-d]

/test connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2428887398
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2428887398
Python tests coverage:

Name                                                 Stmts   Miss  Cover
------------------------------------------------------------------------
source_acceptance_test/utils/__init__.py                 6      0   100%
source_acceptance_test/tests/__init__.py                 4      0   100%
source_acceptance_test/__init__.py                       2      0   100%
source_acceptance_test/tests/test_full_refresh.py       52      2    96%
source_acceptance_test/utils/asserts.py                 37      2    95%
source_acceptance_test/config.py                        77      6    92%
source_acceptance_test/utils/json_schema_helper.py     105     13    88%
source_acceptance_test/tests/test_incremental.py       121     25    79%
source_acceptance_test/utils/common.py                  80     17    79%
source_acceptance_test/tests/test_core.py              294    106    64%
source_acceptance_test/utils/compare.py                 62     23    63%
source_acceptance_test/base.py                          10      4    60%
source_acceptance_test/utils/connector_runner.py       110     48    56%
------------------------------------------------------------------------
TOTAL                                                  960    246    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/google_ads.py               67     10    85%
source_google_ads/streams.py                 163     26    84%
source_google_ads/source.py                   80     23    71%
source_google_ads/custom_query_stream.py      75     46    39%
--------------------------------------------------------------
TOTAL                                        405    105    74%
Name                                       Stmts   Miss  Cover
--------------------------------------------------------------
source_google_ads/models.py                   18      0   100%
source_google_ads/__init__.py                  2      0   100%
source_google_ads/streams.py                 163      8    95%
source_google_ads/source.py                   80      4    95%
source_google_ads/custom_query_stream.py      75      6    92%
source_google_ads/google_ads.py               67     12    82%
--------------------------------------------------------------
TOTAL                                        405     30    93%

Build Passed

Test summary info:

=========================== short test summary info ============================
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestFullRefresh.test_sequential_reads because not found in the config
SKIPPED [1] ../usr/local/lib/python3.9/site-packages/source_acceptance_test/plugin.py:56: Skipping TestIncremental.test_two_sequential_reads because not found in the config
================== 22 passed, 2 skipped in 150.53s (0:02:30) ===================

[davydov-d]

/publish connector=connectors/source-google-ads

🕑 connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2429959272
🚀 Successfully published connectors/source-google-ads
🚀 Auto-bumped version for connectors/source-google-ads
✅ connectors/source-google-ads https://github.com/airbytehq/airbyte/actions/runs/2429959272

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@b5b43d3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master   #13423   +/-   ##
=========================================
  Coverage          ?   92.59%           
=========================================
  Files             ?        6           
  Lines             ?      405           
  Branches          ?        0           
=========================================
  Hits              ?      375           
  Misses            ?       30           
  Partials          ?        0           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5b43d3...86fa317. Read the comment docs.